Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 1642643003: Revert of Fails QUnit.test() after a timeout of 5 seconds. (Closed)

Created:
4 years, 11 months ago by kelvinp
Modified:
4 years, 11 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@FixUT
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fails QUnit.test() after a timeout of 5 seconds. (patchset #2 id:80001 of https://codereview.chromium.org/1638753003/ ) Reason for revert: Test failing on Linux and Mac. Original issue's description: > Fails QUnit.test() after a timeout of 5 seconds. > > Summary of changes: > 1. Fails QUnit.test() it doesn't return within 5 seconds. > Timing dependent tests should use fake timers instead. > 2. Adds an option to disable the timeout when debugging failed tests > locally. > 3. Logs the current test to the console to ease debugging. > > NOTRY=true > > Trybots failing on tests that has already been deleted. > > Committed: https://crrev.com/ed48a6910aace9ad86ef10c2ecdfeae1bb31a40c > Cr-Commit-Position: refs/heads/master@{#371890} TBR=jamiewalch@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/c9a691780a9ef08097d7f58f285714d512650d7e Cr-Commit-Position: refs/heads/master@{#371963}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -76 lines) Patch
M third_party/qunit/README.chromium View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/qunit/src/browser_test_harness.js View 3 chunks +0 lines, -74 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
kelvinp
Created Revert of Fails QUnit.test() after a timeout of 5 seconds.
4 years, 11 months ago (2016-01-28 01:59:51 UTC) #1
Jamie
LGTM, although I feel this CL was a step in the right direction. Do you ...
4 years, 11 months ago (2016-01-28 02:01:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642643003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642643003/1
4 years, 11 months ago (2016-01-28 02:04:26 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-28 02:08:19 UTC) #4
commit-bot: I haz the power
4 years, 11 months ago (2016-01-28 02:10:10 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c9a691780a9ef08097d7f58f285714d512650d7e
Cr-Commit-Position: refs/heads/master@{#371963}

Powered by Google App Engine
This is Rietveld 408576698