Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Side by Side Diff: src/full-codegen/mips/full-codegen-mips.cc

Issue 1642613002: Reland of Type Feedback Vector lives in the closure (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: %SetCode failed to install literals in cache. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS 5 #if V8_TARGET_ARCH_MIPS
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 1189 matching lines...) Expand 10 before | Expand all | Expand 10 after
1200 1200
1201 1201
1202 void FullCodeGenerator::EmitNewClosure(Handle<SharedFunctionInfo> info, 1202 void FullCodeGenerator::EmitNewClosure(Handle<SharedFunctionInfo> info,
1203 bool pretenure) { 1203 bool pretenure) {
1204 // Use the fast case closure allocation code that allocates in new 1204 // Use the fast case closure allocation code that allocates in new
1205 // space for nested functions that don't need literals cloning. If 1205 // space for nested functions that don't need literals cloning. If
1206 // we're running with the --always-opt or the --prepare-always-opt 1206 // we're running with the --always-opt or the --prepare-always-opt
1207 // flag, we need to use the runtime function so that the new function 1207 // flag, we need to use the runtime function so that the new function
1208 // we are creating here gets a chance to have its code optimized and 1208 // we are creating here gets a chance to have its code optimized and
1209 // doesn't just get a copy of the existing unoptimized code. 1209 // doesn't just get a copy of the existing unoptimized code.
1210 if (!FLAG_always_opt && 1210 if (!FLAG_always_opt && !FLAG_prepare_always_opt && !pretenure &&
1211 !FLAG_prepare_always_opt && 1211 scope()->is_function_scope()) {
1212 !pretenure &&
1213 scope()->is_function_scope() &&
1214 info->num_literals() == 0) {
1215 FastNewClosureStub stub(isolate(), info->language_mode(), info->kind()); 1212 FastNewClosureStub stub(isolate(), info->language_mode(), info->kind());
1216 __ li(a2, Operand(info)); 1213 __ li(a2, Operand(info));
1217 __ CallStub(&stub); 1214 __ CallStub(&stub);
1218 } else { 1215 } else {
1219 __ Push(info); 1216 __ Push(info);
1220 __ CallRuntime(pretenure ? Runtime::kNewClosure_Tenured 1217 __ CallRuntime(pretenure ? Runtime::kNewClosure_Tenured
1221 : Runtime::kNewClosure); 1218 : Runtime::kNewClosure);
1222 } 1219 }
1223 context()->Plug(v0); 1220 context()->Plug(v0);
1224 } 1221 }
(...skipping 3576 matching lines...) Expand 10 before | Expand all | Expand 10 after
4801 reinterpret_cast<uint32_t>( 4798 reinterpret_cast<uint32_t>(
4802 isolate->builtins()->OsrAfterStackCheck()->entry())); 4799 isolate->builtins()->OsrAfterStackCheck()->entry()));
4803 return OSR_AFTER_STACK_CHECK; 4800 return OSR_AFTER_STACK_CHECK;
4804 } 4801 }
4805 4802
4806 4803
4807 } // namespace internal 4804 } // namespace internal
4808 } // namespace v8 4805 } // namespace v8
4809 4806
4810 #endif // V8_TARGET_ARCH_MIPS 4807 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/full-codegen/ia32/full-codegen-ia32.cc ('k') | src/full-codegen/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698