Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: src/full-codegen/ia32/full-codegen-ia32.cc

Issue 1642613002: Reland of Type Feedback Vector lives in the closure (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: %SetCode failed to install literals in cache. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/full-codegen.cc ('k') | src/full-codegen/mips/full-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_IA32 5 #if V8_TARGET_ARCH_IA32
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 1116 matching lines...) Expand 10 before | Expand all | Expand 10 after
1127 1127
1128 1128
1129 void FullCodeGenerator::EmitNewClosure(Handle<SharedFunctionInfo> info, 1129 void FullCodeGenerator::EmitNewClosure(Handle<SharedFunctionInfo> info,
1130 bool pretenure) { 1130 bool pretenure) {
1131 // Use the fast case closure allocation code that allocates in new 1131 // Use the fast case closure allocation code that allocates in new
1132 // space for nested functions that don't need literals cloning. If 1132 // space for nested functions that don't need literals cloning. If
1133 // we're running with the --always-opt or the --prepare-always-opt 1133 // we're running with the --always-opt or the --prepare-always-opt
1134 // flag, we need to use the runtime function so that the new function 1134 // flag, we need to use the runtime function so that the new function
1135 // we are creating here gets a chance to have its code optimized and 1135 // we are creating here gets a chance to have its code optimized and
1136 // doesn't just get a copy of the existing unoptimized code. 1136 // doesn't just get a copy of the existing unoptimized code.
1137 if (!FLAG_always_opt && 1137 if (!FLAG_always_opt && !FLAG_prepare_always_opt && !pretenure &&
1138 !FLAG_prepare_always_opt && 1138 scope()->is_function_scope()) {
1139 !pretenure &&
1140 scope()->is_function_scope() &&
1141 info->num_literals() == 0) {
1142 FastNewClosureStub stub(isolate(), info->language_mode(), info->kind()); 1139 FastNewClosureStub stub(isolate(), info->language_mode(), info->kind());
1143 __ mov(ebx, Immediate(info)); 1140 __ mov(ebx, Immediate(info));
1144 __ CallStub(&stub); 1141 __ CallStub(&stub);
1145 } else { 1142 } else {
1146 __ push(Immediate(info)); 1143 __ push(Immediate(info));
1147 __ CallRuntime(pretenure ? Runtime::kNewClosure_Tenured 1144 __ CallRuntime(pretenure ? Runtime::kNewClosure_Tenured
1148 : Runtime::kNewClosure); 1145 : Runtime::kNewClosure);
1149 } 1146 }
1150 context()->Plug(eax); 1147 context()->Plug(eax);
1151 } 1148 }
(...skipping 3564 matching lines...) Expand 10 before | Expand all | Expand 10 after
4716 Assembler::target_address_at(call_target_address, 4713 Assembler::target_address_at(call_target_address,
4717 unoptimized_code)); 4714 unoptimized_code));
4718 return OSR_AFTER_STACK_CHECK; 4715 return OSR_AFTER_STACK_CHECK;
4719 } 4716 }
4720 4717
4721 4718
4722 } // namespace internal 4719 } // namespace internal
4723 } // namespace v8 4720 } // namespace v8
4724 4721
4725 #endif // V8_TARGET_ARCH_IA32 4722 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/full-codegen/full-codegen.cc ('k') | src/full-codegen/mips/full-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698