Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 1642553003: [Android] Switch the x86, x64, and mips builders on chromium.android to mb. (Closed)

Created:
4 years, 11 months ago by jbudorick
Modified:
4 years, 11 months ago
Reviewers:
bpastene, martiniss
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

[Android] Switch the x86, x64, and mips builders on chromium.android to mb. BUG=580129 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298427

Patch Set 1 #

Patch Set 2 : switch to the chromium recipe #

Patch Set 3 : remove android_builder_tests #

Patch Set 4 : Remove Android WebView (amp) #

Total comments: 2

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -1165 lines) Patch
M masters/master.chromium.android/builders.pyl View 1 1 chunk +3 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/amp/example.py View 1 2 3 4 3 chunks +13 lines, -2 lines 0 comments Download
A + scripts/slave/recipe_modules/amp/example.expected/slow_tests_basic.json View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/chromium_config.py View 2 chunks +10 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/config.py View 3 chunks +9 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_android.py View 1 2 3 3 chunks +48 lines, -83 lines 0 comments Download
M scripts/slave/recipes/android/builder.py View 1 chunk +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/android/builder.expected/chromium_android_Android_x64_Builder__dbg__fail_check_licenses.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/android/builder.expected/full_chromium_android_Android_MIPS_Builder__dbg_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/android/builder.expected/full_chromium_android_Android_x64_Builder__dbg_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/android/builder.expected/full_chromium_android_Android_x86_Builder__dbg_.json View 1 chunk +1 line, -0 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_android_Android_MIPS_Builder__dbg_.json View 1 2 6 chunks +8 lines, -18 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_android_Android_WebView__amp_.json View 1 2 3 1 chunk +0 lines, -1001 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_android_Android_arm64_Builder__dbg_.json View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_android_Android_arm_Builder__dbg_.json View 1 2 3 7 chunks +6 lines, -36 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_android_Android_x64_Builder__dbg_.json View 1 2 5 chunks +7 lines, -7 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_android_Android_x86_Builder__dbg_.json View 1 2 5 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
jbudorick
stephen: any idea why these are on android/builder instead of chromium?
4 years, 11 months ago (2016-01-27 16:58:44 UTC) #2
martiniss
On 2016/01/27 at 16:58:44, jbudorick wrote: > stephen: any idea why these are on android/builder ...
4 years, 11 months ago (2016-01-27 20:16:51 UTC) #3
jbudorick
switched to the chromium recipe + muxed in two other changes to recipe_modules/chromium_tests/chromium_android.py: - removed ...
4 years, 11 months ago (2016-01-27 22:22:25 UTC) #4
martiniss
On 2016/01/27 at 22:22:25, jbudorick wrote: > switched to the chromium recipe + muxed in ...
4 years, 11 months ago (2016-01-27 22:28:24 UTC) #5
jbudorick
On 2016/01/27 22:28:24, martiniss wrote: > On 2016/01/27 at 22:22:25, jbudorick wrote: > > switched ...
4 years, 11 months ago (2016-01-27 22:30:17 UTC) #6
martiniss
ohhh ok. Yeah that makes sense. https://codereview.chromium.org/1642553003/diff/60001/scripts/slave/recipe_modules/amp/example.py File scripts/slave/recipe_modules/amp/example.py (right): https://codereview.chromium.org/1642553003/diff/60001/scripts/slave/recipe_modules/amp/example.py#newcode81 scripts/slave/recipe_modules/amp/example.py:81: 'slow_tests': { Why ...
4 years, 11 months ago (2016-01-27 22:43:13 UTC) #7
jbudorick
https://codereview.chromium.org/1642553003/diff/60001/scripts/slave/recipe_modules/amp/example.py File scripts/slave/recipe_modules/amp/example.py (right): https://codereview.chromium.org/1642553003/diff/60001/scripts/slave/recipe_modules/amp/example.py#newcode81 scripts/slave/recipe_modules/amp/example.py:81: 'slow_tests': { On 2016/01/27 22:43:13, martiniss wrote: > Why ...
4 years, 11 months ago (2016-01-27 22:47:53 UTC) #8
martiniss
cool, ok. lgtm
4 years, 11 months ago (2016-01-27 22:49:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642553003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642553003/80001
4 years, 11 months ago (2016-01-27 22:50:53 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 22:54:14 UTC) #13
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298427

Powered by Google App Engine
This is Rietveld 408576698