Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 164253003: Cast: Split kDuplicatePacketReceived into separate events for audio/video. (Closed)

Created:
6 years, 10 months ago by imcheng
Modified:
6 years, 10 months ago
Reviewers:
mikhal1
CC:
chromium-reviews, hclam+watch_chromium.org, mikhal+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, pwestin+watch_google.com, feature-media-reviews_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org, hguihot1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Cast: Split kDuplicatePacketReceived into separate events for audio/video. This change brings this type of event in line with the rest - having separate types for audio / video. As a new type that is potentially sent over in RTCP is introduced, a new RTCP encoding for that type is added as well. This change is backwards-compatible because these events aren't being sent over in RTCP because they are not processed by ReceiverRtcpEventSubscriber. BUG=337901 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251301

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -10 lines) Patch
M media/cast/audio_receiver/audio_receiver.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/logging/logging_defines.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/cast/logging/logging_defines.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/cast/logging/proto/proto_utils.cc View 1 chunk +4 lines, -1 line 0 comments Download
M media/cast/logging/proto/raw_events.proto View 1 chunk +2 lines, -1 line 0 comments Download
M media/cast/rtcp/rtcp.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/cast/rtcp/rtcp_receiver.cc View 1 chunk +3 lines, -1 line 0 comments Download
M media/cast/rtcp/rtcp_sender.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M media/cast/video_receiver/video_receiver.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
imcheng
This is my proposal to fix issue 337901. This should allow the subscriber to tell ...
6 years, 10 months ago (2014-02-13 20:22:48 UTC) #1
mikhal1
lgtm
6 years, 10 months ago (2014-02-13 20:48:33 UTC) #2
imcheng
The CQ bit was checked by imcheng@chromium.org
6 years, 10 months ago (2014-02-13 20:55:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/164253003/1
6 years, 10 months ago (2014-02-13 20:57:16 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 00:51:26 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=201809
6 years, 10 months ago (2014-02-14 00:51:27 UTC) #6
imcheng
The CQ bit was checked by imcheng@chromium.org
6 years, 10 months ago (2014-02-14 01:06:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/164253003/1
6 years, 10 months ago (2014-02-14 01:07:36 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 04:07:57 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=201960
6 years, 10 months ago (2014-02-14 04:07:58 UTC) #10
imcheng
The CQ bit was checked by imcheng@chromium.org
6 years, 10 months ago (2014-02-14 04:39:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/164253003/1
6 years, 10 months ago (2014-02-14 04:41:21 UTC) #12
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 14:02:40 UTC) #13
Message was sent while issue was closed.
Change committed as 251301

Powered by Google App Engine
This is Rietveld 408576698