Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: ppapi/tools/pepper_hash_for_uma.cc

Issue 164253002: Fix output string of pepper_hash_for_uma. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This is a utility executable used for generating hashes for pepper 5 // This is a utility executable used for generating hashes for pepper
6 // interfaces for inclusion in tools/metrics/histograms/histograms.xml. Every 6 // interfaces for inclusion in tools/metrics/histograms/histograms.xml. Every
7 // interface-version pair must have a corresponding entry in the enum there. 7 // interface-version pair must have a corresponding entry in the enum there.
8 // 8 //
9 // The hashing logic here must match the hashing logic at 9 // The hashing logic here must match the hashing logic at
10 // ppapi/proxy/interface_list.cc. 10 // ppapi/proxy/interface_list.cc.
(...skipping 13 matching lines...) Expand all
24 fprintf(stderr, "Example: %s \"PPB_Var;1.1\" \"PPB_FileIO;1.2\"\n", 24 fprintf(stderr, "Example: %s \"PPB_Var;1.1\" \"PPB_FileIO;1.2\"\n",
25 argv[0]); 25 argv[0]);
26 return 1; 26 return 1;
27 } 27 }
28 for (int i = 1; i < argc; i++) { 28 for (int i = 1; i < argc; i++) {
29 uint32 data = base::Hash(argv[i], strlen(argv[i])); 29 uint32 data = base::Hash(argv[i], strlen(argv[i]));
30 30
31 // Strip off the signed bit because UMA doesn't support negative values, 31 // Strip off the signed bit because UMA doesn't support negative values,
32 // but takes a signed int as input. 32 // but takes a signed int as input.
33 int hash = static_cast<int>(data & 0x7fffffff); 33 int hash = static_cast<int>(data & 0x7fffffff);
34 printf("<int value=\"%d\" label=\"%s\">\n", hash, argv[i]); 34 printf("<int value=\"%d\" label=\"%s\"/>\n", hash, argv[i]);
35 } 35 }
36 return 0; 36 return 0;
37 } 37 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698