Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 1642523002: [MemoryCache] Split UMAs for RevalidationPolicy for preloading/regular requests (Closed)

Created:
4 years, 10 months ago by hiroshige
Modified:
4 years, 10 months ago
CC:
chromium-reviews, tyoshino+watch_chromium.org, Yoav Weiss, gavinp+loader_chromium.org, asvitkine+watch_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MemoryCache] Split UMAs for RevalidationPolicy for preloading/regular requests This CL adds Blink.MemoryCache.RevalidationPolicy.Preload.* that collect stats of preloading requests, and makes the existing Blink.MemoryCache.RevalidationPolicy.* to collect stats of non-preloading requests only. BUG=579496 Committed: https://crrev.com/28808177b616c932c881c842653d9899c32b72f7 Cr-Commit-Position: refs/heads/master@{#372009}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642523002/1
4 years, 10 months ago (2016-01-27 08:43:38 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642523002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642523002/20001
4 years, 10 months ago (2016-01-27 08:44:48 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-01-27 10:09:23 UTC) #8
hiroshige
PTAL.
4 years, 10 months ago (2016-01-27 10:14:55 UTC) #9
Nate Chapin
LGTM
4 years, 10 months ago (2016-01-27 23:32:37 UTC) #10
Ilya Sherman
LGTM
4 years, 10 months ago (2016-01-28 01:46:46 UTC) #11
Nate Chapin
On 2016/01/27 23:32:37, Nate Chapin wrote: > LGTM It might also be interesting to split ...
4 years, 10 months ago (2016-01-28 03:17:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642523002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642523002/20001
4 years, 10 months ago (2016-01-28 04:14:03 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-28 04:20:51 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 04:22:02 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/28808177b616c932c881c842653d9899c32b72f7
Cr-Commit-Position: refs/heads/master@{#372009}

Powered by Google App Engine
This is Rietveld 408576698