Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1642503002: Implement Node.treeRoot (Closed)

Created:
4 years, 11 months ago by yuzuchan
Modified:
4 years, 10 months ago
Reviewers:
kojii, hayato, yuzusan, kochi
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement Node.treeRoot Node.treeRoot is implemented to formalize the way that elements figure out the root/shadowroot. See the discussion here: https://github.com/w3c/webcomponents/issues/80 See the Spec change here: https://github.com/w3c/webcomponents/commit/6864a40fe4efa8a737e78512e3c85319ddc5bf8b See the Spec here: http://w3c.github.io/webcomponents/spec/shadow/#widl-Node-treeRoot BUG=579873, 531990 Committed: https://crrev.com/df6916adc8e8fe1daa591955b0575663d4f00990 Cr-Commit-Position: refs/heads/master@{#372626}

Patch Set 1 #

Total comments: 14

Patch Set 2 : Fix layout test results #

Patch Set 3 : Add if case for detached tree #

Total comments: 10

Patch Set 4 : Add test cases #

Total comments: 5

Patch Set 5 : Change return type and clean up the layout test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/dom/shadow/treeRoot.html View 1 2 3 4 1 chunk +84 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt View 1 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.idl View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
yuzuchan
4 years, 11 months ago (2016-01-27 07:32:31 UTC) #3
kochi
https://codereview.chromium.org/1642503002/diff/1/third_party/WebKit/LayoutTests/fast/dom/Node/treeRoot.html File third_party/WebKit/LayoutTests/fast/dom/Node/treeRoot.html (right): https://codereview.chromium.org/1642503002/diff/1/third_party/WebKit/LayoutTests/fast/dom/Node/treeRoot.html#newcode2 third_party/WebKit/LayoutTests/fast/dom/Node/treeRoot.html:2: <html> You can omit <html><head><body> (and their closing counterparts ...
4 years, 11 months ago (2016-01-27 09:18:50 UTC) #4
kochi
Please update the BUG= reference in the description to be "BUG=579873".
4 years, 10 months ago (2016-01-28 03:26:49 UTC) #5
yuzuchan
https://codereview.chromium.org/1642503002/diff/1/third_party/WebKit/LayoutTests/fast/dom/Node/treeRoot.html File third_party/WebKit/LayoutTests/fast/dom/Node/treeRoot.html (right): https://codereview.chromium.org/1642503002/diff/1/third_party/WebKit/LayoutTests/fast/dom/Node/treeRoot.html#newcode2 third_party/WebKit/LayoutTests/fast/dom/Node/treeRoot.html:2: <html> On 2016/01/27 09:18:49, kochi wrote: > You can ...
4 years, 10 months ago (2016-01-28 06:23:57 UTC) #7
kochi
https://codereview.chromium.org/1642503002/diff/40001/third_party/WebKit/LayoutTests/fast/dom/Node/treeRoot.html File third_party/WebKit/LayoutTests/fast/dom/Node/treeRoot.html (right): https://codereview.chromium.org/1642503002/diff/40001/third_party/WebKit/LayoutTests/fast/dom/Node/treeRoot.html#newcode1 third_party/WebKit/LayoutTests/fast/dom/Node/treeRoot.html:1: <!DOCTYPE html> Usually we have used fast/dom/shadow for any ...
4 years, 10 months ago (2016-01-28 06:46:11 UTC) #8
yuzuchan
PTAL https://codereview.chromium.org/1642503002/diff/40001/third_party/WebKit/LayoutTests/fast/dom/Node/treeRoot.html File third_party/WebKit/LayoutTests/fast/dom/Node/treeRoot.html (right): https://codereview.chromium.org/1642503002/diff/40001/third_party/WebKit/LayoutTests/fast/dom/Node/treeRoot.html#newcode1 third_party/WebKit/LayoutTests/fast/dom/Node/treeRoot.html:1: <!DOCTYPE html> On 2016/01/28 06:46:11, kochi wrote: > ...
4 years, 10 months ago (2016-02-01 04:59:54 UTC) #9
hayato
https://codereview.chromium.org/1642503002/diff/60001/third_party/WebKit/Source/core/dom/Node.h File third_party/WebKit/Source/core/dom/Node.h (right): https://codereview.chromium.org/1642503002/diff/60001/third_party/WebKit/Source/core/dom/Node.h#newcode217 third_party/WebKit/Source/core/dom/Node.h:217: Node* treeRoot(); This can be: Node& treeRoot() const;
4 years, 10 months ago (2016-02-01 05:48:47 UTC) #10
kochi
https://codereview.chromium.org/1642503002/diff/60001/third_party/WebKit/LayoutTests/fast/dom/shadow/treeRoot.html File third_party/WebKit/LayoutTests/fast/dom/shadow/treeRoot.html (right): https://codereview.chromium.org/1642503002/diff/60001/third_party/WebKit/LayoutTests/fast/dom/shadow/treeRoot.html#newcode55 third_party/WebKit/LayoutTests/fast/dom/shadow/treeRoot.html:55: test(function() { I would suggest that you put line ...
4 years, 10 months ago (2016-02-01 06:10:11 UTC) #11
yuzuchan
https://codereview.chromium.org/1642503002/diff/60001/third_party/WebKit/LayoutTests/fast/dom/shadow/treeRoot.html File third_party/WebKit/LayoutTests/fast/dom/shadow/treeRoot.html (right): https://codereview.chromium.org/1642503002/diff/60001/third_party/WebKit/LayoutTests/fast/dom/shadow/treeRoot.html#newcode55 third_party/WebKit/LayoutTests/fast/dom/shadow/treeRoot.html:55: test(function() { On 2016/02/01 06:10:11, kochi wrote: > I ...
4 years, 10 months ago (2016-02-01 08:38:51 UTC) #12
hayato
lgtm
4 years, 10 months ago (2016-02-01 09:08:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642503002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642503002/80001
4 years, 10 months ago (2016-02-01 09:09:05 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 10 months ago (2016-02-01 09:14:59 UTC) #17
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 09:16:31 UTC) #19
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/df6916adc8e8fe1daa591955b0575663d4f00990
Cr-Commit-Position: refs/heads/master@{#372626}

Powered by Google App Engine
This is Rietveld 408576698