Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Unified Diff: Source/core/html/HTMLStyleElement.cpp

Issue 16425002: Moved StyleElement::insertedIntoDocument into didNotifySubtreeInsertions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLStyleElement.cpp
diff --git a/Source/core/html/HTMLStyleElement.cpp b/Source/core/html/HTMLStyleElement.cpp
index 05eadff4961955d2fe970c40729f007a7c57f35a..7b9aca8bf103775408fc8c19ee6cda8e4ca1c5fb 100644
--- a/Source/core/html/HTMLStyleElement.cpp
+++ b/Source/core/html/HTMLStyleElement.cpp
@@ -174,7 +174,7 @@ Node::InsertionNotificationRequest HTMLStyleElement::insertedInto(ContainerNode*
if (insertionPoint->inDocument()) {
if (m_scopedStyleRegistrationState == NotRegistered && (scoped() || isInShadowTree()))
registerWithScopingNode(scoped());
- StyleElement::insertedIntoDocument(document(), this);
+ return InsertionShouldCallDidNotifySubtreeInsertions;
}
return InsertionDone;
@@ -203,6 +203,11 @@ void HTMLStyleElement::removedFrom(ContainerNode* insertionPoint)
StyleElement::removedFromDocument(document(), this);
}
+void HTMLStyleElement::didNotifySubtreeInsertions(ContainerNode* insertionPoint)
+{
+ StyleElement::insertedIntoDocument(document(), this);
Hajime Morrita 2013/06/05 07:21:06 This should no longer be insertedIntoDocument().
tasak 2013/06/05 08:30:52 Done.
+}
+
void HTMLStyleElement::childrenChanged(bool changedByParser, Node* beforeChange, Node* afterChange, int childCountDelta)
{
HTMLElement::childrenChanged(changedByParser, beforeChange, afterChange, childCountDelta);

Powered by Google App Engine
This is Rietveld 408576698