pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart - Issue 1642493002: Add type info to JSArray.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart

Issue 1642493002: Add type info to JSArray. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: array changes Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart

diff --git a/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart b/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart

index d6f17694116388573ef87ad37ea3984f1d9ba4d6..6d2ce7eac423dcdf705f20d0a394bb6cf3b58db8 100644

--- a/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart

+++ b/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart

@@ -523,7 +523,9 @@ class SubexpressionVisitor extends ExpressionVisitor<String> {

@override

String visitTypeExpression(TypeExpression node) {

- return node.dartType.toString();

+ String kind = '${node.kind}'.split('.').last;

+ String args = node.arguments.map(visitExpression).join(', ');

+ return 'TypeExpression($kind, ${node.dartType}, $args)';

}

@override