Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart

Issue 1642493002: Add type info to JSArray. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: array changes Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart
index 9fa4144d97de32d5bcde8ffad1ccf2f8efdaca6a..8db31e48a0c17000fefda775a853a81acac33223 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart
@@ -2411,7 +2411,7 @@ class IrBuilder {
arguments.add(value);
}
return addPrimitive(new ir.CreateInstance(
- classElement, arguments, const <ir.Primitive>[], sourceInformation));
+ classElement, arguments, null, sourceInformation));
}
/// Create a read access of [local] function, variable, or parameter.
@@ -2555,9 +2555,9 @@ class IrBuilder {
InterfaceType interface = type;
Iterable<ir.Primitive> typeArguments =
interface.typeArguments.map((DartType argument) {
- return type.treatAsRaw
- ? buildNullConstant()
- : buildTypeExpression(argument);
+ return type.treatAsRaw
+ ? buildNullConstant()
+ : buildTypeExpression(argument);
});
arguments = new List<ir.Primitive>.from(arguments)
..addAll(typeArguments);
@@ -2577,7 +2577,8 @@ class IrBuilder {
ir.Primitive value = buildTypeVariableAccess(variable);
arguments.add(value);
});
- return addPrimitive(new ir.TypeExpression(type, arguments));
+ return addPrimitive(new ir.TypeExpression(ir.TypeExpressionKind.COMPLETE,
+ type, arguments));
} else if (type.treatAsDynamic) {
return buildNullConstant();
} else {

Powered by Google App Engine
This is Rietveld 408576698