Add type info to JSArray.

Add type info to JSArray.

JSArray<E>.typed has a specially generated body. We should be able to inline this. This makes all of the "new List.xxx()" paths work.

Literal lists are treated like maps - we generate a call to JSArray<E>.typed.  I need to change that to JSArray<E>.markGrowable.

R=asgerf@google.com

Committed: https://github.com/dart-lang/sdk/commit/1673a648491211addd576f33cfaff794cc721eac

[sra1, 2016-01-27 07:04:34]

Description was changed from

==========
Add type info to JSArray.

JSArray<E>.typed has a specially generated body. We should be able to inline
this.
==========

to

==========
Add type info to JSArray.

JSArray<E>.typed has a specially generated body. We should be able to inline
this. This makes all of the "new List.xxx()" paths work.

Literal lists are treated like maps - we generate a call to JSArray<E>.typed.  I
need to change that to JSArray<E>.markGrowable.
==========

[sra1, 2016-01-27 07:04:34]

sra@google.com changed reviewers:
+ asgerf@google.com, kmillikin@gmail.com

[sra1, 2016-01-27 07:06:08]

This is a patch on top of my pending TypeExpression CL.

https://codereview.chromium.org/1642493002/diff/20001/pkg/compiler/lib/src/cp...
File pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart (right):

https://codereview.chromium.org/1642493002/diff/20001/pkg/compiler/lib/src/cp...
pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:896: if
(requiresRuntimeTypes) {
This caused a mismatch between call site and callee when the types could be
erased.
It occurs to me that inlining might have similar issues.

https://codereview.chromium.org/1642493002/diff/20001/pkg/compiler/lib/src/cp...
pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:1607: ConstructorElement
constructor = helpers.jsArrayTypedConstructor;
There is a small issue here with losing type precision - we should call
jsArray.markGrowable (literals are growable) and/or insert a refinement to the
allocationSiteType.

[sra1, 2016-01-27 15:56:47]

sra@google.com changed reviewers:
+ kmillikin@google.com
- kmillikin@gmail.com

[sra1, 2016-01-27 15:57:14]

Ping

[asgerf, 2016-01-27 16:08:03]

LGTM.

[sra1, 2016-01-27 21:47:24]

Description was changed from

==========
Add type info to JSArray.

JSArray<E>.typed has a specially generated body. We should be able to inline
this. This makes all of the "new List.xxx()" paths work.

Literal lists are treated like maps - we generate a call to JSArray<E>.typed.  I
need to change that to JSArray<E>.markGrowable.
==========

to

==========
Add type info to JSArray.

JSArray<E>.typed has a specially generated body. We should be able to inline
this. This makes all of the "new List.xxx()" paths work.

Literal lists are treated like maps - we generate a call to JSArray<E>.typed.  I
need to change that to JSArray<E>.markGrowable.

R=asgerf@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1673a648491211addd576f33cfaff794cc721eac
==========

[sra1, 2016-01-27 21:47:25]

Committed patchset #3 (id:40001) manually as
1673a648491211addd576f33cfaff794cc721eac (presubmit successful).