third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp - Issue 1642463004: Extended error reporting for SVG path parsing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

Issue 1642463004: Extended error reporting for SVG path parsing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

index 88d4ec8c1ff4bbd92ccf6866c4980bf0eb2fdf3e..9b2a5a60b9cdf301420615f91fc4f9122f4b992d 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

@@ -1937,7 +1937,8 @@ static PassRefPtrWillBeRawPtr<CSSValue> consumePath(CSSParserTokenRange& range)

String pathString = functionArgs.consumeIncludingWhitespace().value();

RefPtr<SVGPathByteStream> byteStream = SVGPathByteStream::create();

- if (!buildByteStreamFromString(pathString, *byteStream) || !functionArgs.atEnd())

+ if (buildByteStreamFromString(pathString, *byteStream) != SVGParseStatus::NoError

+ || !functionArgs.atEnd())

return nullptr;

range = functionRange;