Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGPathUtilities.cpp

Issue 1642463004: Extended error reporting for SVG path parsing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: "path flag" -> "arc flag" Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGPathUtilities.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) Research In Motion Limited 2010, 2012. All rights reserved. 2 * Copyright (C) Research In Motion Limited 2010, 2012. All rights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 if (stream.isEmpty()) 55 if (stream.isEmpty())
56 return String(); 56 return String();
57 57
58 SVGPathStringBuilder builder; 58 SVGPathStringBuilder builder;
59 SVGPathByteStreamSource source(stream); 59 SVGPathByteStreamSource source(stream);
60 SVGPathParser parser(&source, &builder); 60 SVGPathParser parser(&source, &builder);
61 parser.parsePathDataFromSource(); 61 parser.parsePathDataFromSource();
62 return builder.result(); 62 return builder.result();
63 } 63 }
64 64
65 bool buildByteStreamFromString(const String& d, SVGPathByteStream& result) 65 SVGParsingError buildByteStreamFromString(const String& d, SVGPathByteStream& re sult)
66 { 66 {
67 result.clear(); 67 result.clear();
68 if (d.isEmpty()) 68 if (d.isEmpty())
69 return true; 69 return SVGParseStatus::NoError;
70 70
71 // The string length is typically a minor overestimate of eventual byte stre am size, so it avoids us a lot of reallocs. 71 // The string length is typically a minor overestimate of eventual byte stre am size, so it avoids us a lot of reallocs.
72 result.reserveInitialCapacity(d.length()); 72 result.reserveInitialCapacity(d.length());
73 73
74 SVGPathByteStreamBuilder builder(result); 74 SVGPathByteStreamBuilder builder(result);
75 SVGPathStringSource source(d); 75 SVGPathStringSource source(d);
76 SVGPathParser parser(&source, &builder); 76 SVGPathParser parser(&source, &builder);
77 bool ok = parser.parsePathDataFromSource(); 77 parser.parsePathDataFromSource();
78 result.shrinkToFit(); 78 result.shrinkToFit();
79 return ok; 79 return source.parseError();
80 } 80 }
81 81
82 } // namespace blink 82 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGPathUtilities.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698