Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGPath.cpp

Issue 1642463004: Extended error reporting for SVG path parsing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: "path flag" -> "arc flag" Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann <zimmermann@kde .org> 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann <zimmermann@kde .org>
3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org>
4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
5 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 5 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 } 88 }
89 89
90 90
91 PassRefPtrWillBeRawPtr<SVGPath> SVGPath::clone() const 91 PassRefPtrWillBeRawPtr<SVGPath> SVGPath::clone() const
92 { 92 {
93 return SVGPath::create(m_pathValue); 93 return SVGPath::create(m_pathValue);
94 } 94 }
95 95
96 SVGParsingError SVGPath::setValueAsString(const String& string) 96 SVGParsingError SVGPath::setValueAsString(const String& string)
97 { 97 {
98 SVGParsingError parseStatus;
99 RefPtr<SVGPathByteStream> byteStream = SVGPathByteStream::create(); 98 RefPtr<SVGPathByteStream> byteStream = SVGPathByteStream::create();
100 if (!buildByteStreamFromString(string, *byteStream)) 99 SVGParsingError parseStatus = buildByteStreamFromString(string, *byteStream) ;
101 parseStatus = SVGParseStatus::ParsingFailed;
102 m_pathValue = CSSPathValue::create(byteStream.release()); 100 m_pathValue = CSSPathValue::create(byteStream.release());
103 return parseStatus; 101 return parseStatus;
104 } 102 }
105 103
106 PassRefPtrWillBeRawPtr<SVGPropertyBase> SVGPath::cloneForAnimation(const String& value) const 104 PassRefPtrWillBeRawPtr<SVGPropertyBase> SVGPath::cloneForAnimation(const String& value) const
107 { 105 {
108 return SVGPath::create(CSSPathValue::create(value)); 106 return SVGPath::create(CSSPathValue::create(value));
109 } 107 }
110 108
111 void SVGPath::add(PassRefPtrWillBeRawPtr<SVGPropertyBase> other, SVGElement*) 109 void SVGPath::add(PassRefPtrWillBeRawPtr<SVGPropertyBase> other, SVGElement*)
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 return -1; 170 return -1;
173 } 171 }
174 172
175 DEFINE_TRACE(SVGPath) 173 DEFINE_TRACE(SVGPath)
176 { 174 {
177 visitor->trace(m_pathValue); 175 visitor->trace(m_pathValue);
178 SVGPropertyBase::trace(visitor); 176 SVGPropertyBase::trace(visitor);
179 } 177 }
180 178
181 } // namespace blink 179 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGParsingError.cpp ('k') | third_party/WebKit/Source/core/svg/SVGPathParserTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698