Extended error reporting for SVG path parsing

third_party/WebKit/Source/core/svg/SVGParsingError.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/svg/SVGParsingError.h"
 
 #include "core/dom/QualifiedName.h"
 #include "platform/JSONValues.h"
 #include "wtf/text/CharacterNames.h"
 #include "wtf/text/StringBuilder.h"
@@ skipping 10 matching lines @@
     builder.append(tagName);
     builder.appendLiteral("> attribute ");
     builder.append(name.toString());
 }
 
 std::pair<const char*, const char*> messageForStatus(SVGParseStatus status)
 {
     switch (status) {
     case SVGParseStatus::TrailingGarbage:
         return std::make_pair("Trailing garbage, ", ".");
+    case SVGParseStatus::ExpectedArcFlag:
+        return std::make_pair("Expected path flag ('0' or '1'), ", ".");

[f(malita), 2016/01/27 14:51:13]

Nit: "Expected arc flag"? Or maybe you're planning to use this for other flags
too - then maybe change the enum to ExpectedPathFlag?

[fs, 2016/01/27 14:57:56]

Yes, I think I had intended to say "arc flag" here... Will fix.

     case SVGParseStatus::ExpectedBoolean:
         return std::make_pair("Expected 'true' or 'false', ", ".");
     case SVGParseStatus::ExpectedEnumeration:
         return std::make_pair("Unrecognized enumerated value, ", ".");
     case SVGParseStatus::ExpectedLength:
         return std::make_pair("Expected length, ", ".");
+    case SVGParseStatus::ExpectedMoveToCommand:
+        return std::make_pair("Expected moveto path command ('M' or 'm'), ", ".");
     case SVGParseStatus::ExpectedNumber:
         return std::make_pair("Expected number, ", ".");
+    case SVGParseStatus::ExpectedPathCommand:
+        return std::make_pair("Expected path command, ", ".");
     case SVGParseStatus::NegativeValue:
         return std::make_pair("A negative value is not valid. (", ")");
     case SVGParseStatus::ParsingFailed:
     default:
         ASSERT_NOT_REACHED();
         break;
     }
     return std::make_pair("", "");
 }
 
@@ skipping 51 matching lines @@
 
         auto message = messageForStatus(status());
         builder.append(message.first);
         appendValue(builder, *this, value);
         builder.append(message.second);
     }
     return builder.toString();
 }
 
 } // namespace blink