Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16424008: move webkit/glue/fling_* to webkit/child (Closed)

Created:
7 years, 6 months ago by scottmg
Modified:
7 years, 6 months ago
Reviewers:
jamesr, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

move webkit/glue/fling_* to webkit/child A little bit of rejiggering for Android JNI registration. R=jam@chromium.org, jamesr@chromium.org BUG=237249 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206148

Patch Set 1 #

Patch Set 2 : add DEPS exclusion for webkit/child #

Patch Set 3 : split out child jni registration #

Patch Set 4 : gypi and rebase #

Patch Set 5 : android overscroller jni generation #

Total comments: 2

Patch Set 6 : generated android #

Patch Set 7 : android 2 #

Patch Set 8 : android 3 #

Patch Set 9 : android 4 #

Patch Set 10 : android 5 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -400 lines) Patch
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M content/app/android/library_loader_hooks.cc View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
A content/child/android/child_jni_registrar.h View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
A + content/child/android/child_jni_registrar.cc View 1 2 2 chunks +5 lines, -8 lines 0 comments Download
M content/common/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/common/android/common_jni_registrar.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_child.gypi View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -1 line 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 6 3 chunks +3 lines, -0 lines 0 comments Download
A webkit/child/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A + webkit/child/fling_animator_impl_android.h View 1 2 3 4 5 4 chunks +5 lines, -5 lines 0 comments Download
A + webkit/child/fling_animator_impl_android.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/child/fling_curve_configuration.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/child/fling_curve_configuration.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/child/webkitplatformsupport_child_impl.h View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
M webkit/child/webkitplatformsupport_child_impl.cc View 1 2 3 1 chunk +32 lines, -2 lines 0 comments Download
D webkit/glue/fling_animator_impl_android.h View 1 chunk +0 lines, -58 lines 0 comments Download
D webkit/glue/fling_animator_impl_android.cc View 1 chunk +0 lines, -148 lines 0 comments Download
D webkit/glue/fling_curve_configuration.h View 1 chunk +0 lines, -58 lines 0 comments Download
D webkit/glue/fling_curve_configuration.cc View 1 chunk +0 lines, -55 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 2 3 4 5 6 7 8 3 chunks +15 lines, -13 lines 0 comments Download
M webkit/glue/webkitplatformsupport_impl.h View 1 2 3 4 chunks +0 lines, -11 lines 0 comments Download
M webkit/glue/webkitplatformsupport_impl.cc View 1 2 3 5 chunks +4 lines, -34 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scottmg
jamesr: webkit/ jam: content/ and chrome/
7 years, 6 months ago (2013-06-12 19:25:16 UTC) #1
jamesr
https://codereview.chromium.org/16424008/diff/24001/webkit/child/fling_animator_impl_android.h File webkit/child/fling_animator_impl_android.h (right): https://codereview.chromium.org/16424008/diff/24001/webkit/child/fling_animator_impl_android.h#newcode22 webkit/child/fling_animator_impl_android.h:22: class WEBKIT_GLUE_EXPORT FlingAnimatorImpl : public WebKit::WebGestureCurve { why not ...
7 years, 6 months ago (2013-06-12 19:28:15 UTC) #2
scottmg
https://codereview.chromium.org/16424008/diff/24001/webkit/child/fling_animator_impl_android.h File webkit/child/fling_animator_impl_android.h (right): https://codereview.chromium.org/16424008/diff/24001/webkit/child/fling_animator_impl_android.h#newcode22 webkit/child/fling_animator_impl_android.h:22: class WEBKIT_GLUE_EXPORT FlingAnimatorImpl : public WebKit::WebGestureCurve { On 2013/06/12 ...
7 years, 6 months ago (2013-06-12 19:31:10 UTC) #3
jamesr
lgtm
7 years, 6 months ago (2013-06-12 19:36:09 UTC) #4
jam
lgtm
7 years, 6 months ago (2013-06-12 20:13:05 UTC) #5
scottmg
7 years, 6 months ago (2013-06-13 20:02:42 UTC) #6
Message was sent while issue was closed. 
Committed patchset #10 manually as r206148.

Powered by Google App Engine
This is Rietveld 408576698