Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: ui/login/account_picker/user_pod_row.js

Issue 1642323004: User Manager MD User Pods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comment, rebase, and fix for browser test Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/login/account_picker/user_pod_row.css ('k') | ui/login/account_picker/user_pod_template.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/login/account_picker/user_pod_row.js
diff --git a/ui/login/account_picker/user_pod_row.js b/ui/login/account_picker/user_pod_row.js
index 8bc93b994df65ad939d0d32c3cbd65d525d0d9c1..5beacb4da486f9c79e68ba4d0c418e1375159582 100644
--- a/ui/login/account_picker/user_pod_row.js
+++ b/ui/login/account_picker/user_pod_row.js
@@ -28,7 +28,7 @@ cr.define('login', function() {
* @type {Array<number>}
* @const
*/
- var DESKTOP_MARGIN_BY_COLUMNS = [undefined, 15, 15, 15, 15, 15, 15];
+ var DESKTOP_MARGIN_BY_COLUMNS = [undefined, 32, 32, 32, 32, 32, 32];
/**
* Maximal number of columns currently supported by pod-row.
@@ -48,13 +48,16 @@ cr.define('login', function() {
* Variables used for pod placement processing. Width and height should be
* synced with computed CSS sizes of pods.
*/
- var POD_WIDTH = 180;
+ var CROS_POD_WIDTH = 180;
+ var DESKTOP_POD_WIDTH = 180;
+ var MD_DESKTOP_POD_WIDTH = 160;
var PUBLIC_EXPANDED_BASIC_WIDTH = 500;
var PUBLIC_EXPANDED_ADVANCED_WIDTH = 610;
var CROS_POD_HEIGHT = 213;
var DESKTOP_POD_HEIGHT = 226;
+ var MD_DESKTOP_POD_HEIGHT = 200;
var POD_ROW_PADDING = 10;
- var DESKTOP_ROW_PADDING = 15;
+ var DESKTOP_ROW_PADDING = 32;
var CUSTOM_ICON_CONTAINER_SIZE = 40;
/**
@@ -1548,19 +1551,26 @@ cr.define('login', function() {
if (profilePath !== this.user.profilePath)
return;
// Add localized messages where $1 will be replaced with
- // <span class="total-count"></span>.
+ // <span class="total-count"></span> and $2 will be replaced with
+ // <span class="email"></span>.
var element = this.querySelector('.action-box-remove-user-warning-text');
element.textContent = '';
- messageParts = message.split('$1');
+ messageParts = message.split(/(\$[12])/);
var numParts = messageParts.length;
for (var j = 0; j < numParts; j++) {
- element.appendChild(document.createTextNode(messageParts[j]));
- if (j < numParts - 1) {
+ if (messageParts[j] === '$1') {
var elementToAdd = document.createElement('span');
elementToAdd.classList.add('total-count');
elementToAdd.textContent = count;
element.appendChild(elementToAdd);
+ } else if (messageParts[j] === '$2') {
+ var elementToAdd = document.createElement('span');
+ elementToAdd.classList.add('email');
+ elementToAdd.textContent = this.user.emailAddress;
+ element.appendChild(elementToAdd);
+ } else {
+ element.appendChild(document.createTextNode(messageParts[j]));
}
}
this.moveActionMenuUpIfNeeded_();
@@ -2312,10 +2322,15 @@ cr.define('login', function() {
var isDesktopUserManager = Oobe.getInstance().displayType ==
DISPLAY_TYPE.DESKTOP_USER_MANAGER;
- this.userPodHeight_ = isDesktopUserManager ? DESKTOP_POD_HEIGHT :
- CROS_POD_HEIGHT;
- // Same for Chrome OS and desktop.
- this.userPodWidth_ = POD_WIDTH;
+ var isNewDesktopUserManager = Oobe.getInstance().newDesktopUserManager;
+ this.userPodHeight_ = isDesktopUserManager ?
+ isNewDesktopUserManager ? MD_DESKTOP_POD_HEIGHT :
+ DESKTOP_POD_HEIGHT :
+ CROS_POD_HEIGHT;
+ this.userPodWidth_ = isDesktopUserManager ?
+ isNewDesktopUserManager ? MD_DESKTOP_POD_WIDTH :
+ DESKTOP_POD_WIDTH :
+ CROS_POD_WIDTH;
},
/**
@@ -2793,9 +2808,11 @@ cr.define('login', function() {
$('signin-banner'), null).getPropertyValue('display') != 'none') {
rows = Math.min(rows, MAX_NUMBER_OF_ROWS_UNDER_SIGNIN_BANNER);
}
- var maxHeigth = Oobe.getInstance().clientAreaSize.height;
- while (maxHeigth < this.rowsToHeight_(rows) && rows > 1)
- --rows;
+ if (!Oobe.getInstance().newDesktopUserManager) {
+ var maxHeigth = Oobe.getInstance().clientAreaSize.height;
+ while (maxHeigth < this.rowsToHeight_(rows) && rows > 1)
+ --rows;
+ }
// One more iteration if it's not enough cells to place all pods.
while (maxWidth >= this.columnsToWidth_(columns + 1) &&
columns * rows < this.pods.length &&
« no previous file with comments | « ui/login/account_picker/user_pod_row.css ('k') | ui/login/account_picker/user_pod_template.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698