User Manager MD User Pods

chrome/browser/resources/md_user_manager/user_manager.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="../../../../ui/login/screen.js">
 <include src="../../../../ui/login/bubble.js">
 <include src="../../../../ui/login/login_ui_tools.js">
 <include src="../../../../ui/login/display_manager.js">
 <include src="../../../../ui/login/account_picker/screen_account_picker.js">
 <include src="../../../../ui/login/account_picker/user_pod_row.js">
 
 
 cr.define('cr.ui', function() {
   var DisplayManager = cr.ui.login.DisplayManager;
 
   /**
    * Manages initialization of screens, transitions, and error messages.
    * @constructor
    * @extends {DisplayManager}
   */
   function UserManager() {}
 
   cr.addSingletonGetter(UserManager);
 
   UserManager.prototype = {
     __proto__: DisplayManager.prototype,
+
+    /**
+     * @override
+     * Overrides clientAreaSize in DisplayManager. When a new profile is created
+     * the #outer-container page may not be visible yet, so user-pods cannot be
+     * placed correctly. In that case we use dimensions of the #animated-pages.
+     * @type {{width:string, height:string}}

[tommycli, 2016/03/11 18:59:14]

I think it should be {width: string, height: string} (spaces)

[Moe, 2016/03/15 21:28:20]

Done.

+     */
+    get clientAreaSize() {
+      var outerContainer = $('outer-container');
+      var animatedPages = $('animatedPages');
+      var width = outerContainer.offsetWidth || animatedPages.offsetWidth;
+      // Deduct the maximum possible height of the #login-header-bar (including
+      // the padding and the border) from the height of #animated-pages. Result
+      // is the remaining visible height.
+      var height = outerContainer.offsetHeight ||
+          animatedPages.offsetHeight - 57;

[tommycli, 2016/03/11 18:59:14]

Can this '57' value be calculated from the element instead of a constant?

[Moe, 2016/03/15 21:28:20]

I removed the constant from the css file. Unfortunately I can't think of a way
to get rid of it here too. The #login-header-bar is not always visible when
user_pod_row.js accesses this property in order to arrange the user pods. 

+      return {width: width, height: height};
+    }
   };
 
   /**
    * Initializes the UserManager.
    */
   UserManager.initialize = function() {
     cr.ui.login.DisplayManager.initialize();
     login.AccountPickerScreen.register();
     cr.ui.Bubble.decorate($('bubble'));
 
@@ skipping 75 matching lines @@
 // Allow selection events on components with editable text (password field)
 // bug (http://code.google.com/p/chromium/issues/detail?id=125863)
 disableTextSelectAndDrag(function(e) {
   var src = e.target;
   return src instanceof HTMLTextAreaElement ||
          src instanceof HTMLInputElement &&
          /text|password|search/.test(src.type);
 });
 
 document.addEventListener('DOMContentLoaded', cr.ui.UserManager.initialize);