Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1642323002:
rewrite_to_chrome_style: Fix assert calling getName() when there's none (Closed)
Descriptionrewrite_to_chrome_style: Fix assert calling getName() when there's none
When there's no identifier to rename, don't try to
GetNameForDecl(), and always use getName() consistently.
R=dcheng
BUG=578344, 581902
Committed: https://crrev.com/98ce11e5cca3e666a5034d85eab5823eaaec259a
Cr-Commit-Position: refs/heads/master@{#372245}
Patch Set 1 #
Total comments: 2
Patch Set 2 : rewrite-getname: . #Patch Set 3 : rewrite-getname: rebase #Messages
Total messages: 22 (11 generated)
The CQ bit was checked by danakj@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642323002/1
Description was changed from ========== rewrite_to_chrome_style: Fix assert calling getName() when there's none When there's no identifier to rename, just return false from GetNameForDecl(), and always use getName() consistently. R=dcheng BUG=578344 ========== to ========== rewrite_to_chrome_style: Fix assert calling getName() when there's none When there's no identifier to rename, just return false from GetNameForDecl(), and always use getName() consistently. R=dcheng BUG=578344,581902 ==========
https://codereview.chromium.org/1642323002/diff/1/tools/clang/rewrite_to_chro... File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right): https://codereview.chromium.org/1642323002/diff/1/tools/clang/rewrite_to_chro... tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:169: if (!decl.getIdentifier()) Does it makes sense to move this into RewriteBase::run(), after we get the decl?
PTAL https://codereview.chromium.org/1642323002/diff/1/tools/clang/rewrite_to_chro... File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right): https://codereview.chromium.org/1642323002/diff/1/tools/clang/rewrite_to_chro... tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:169: if (!decl.getIdentifier()) On 2016/01/29 01:13:05, dcheng wrote: > Does it makes sense to move this into RewriteBase::run(), after we get the decl? Hm ya sure.
The CQ bit was checked by danakj@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642323002/20001
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
The CQ bit was checked by danakj@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org Link to the patchset: https://codereview.chromium.org/1642323002/#ps40001 (title: "rewrite-getname: rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642323002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642323002/40001
Description was changed from ========== rewrite_to_chrome_style: Fix assert calling getName() when there's none When there's no identifier to rename, just return false from GetNameForDecl(), and always use getName() consistently. R=dcheng BUG=578344,581902 ========== to ========== rewrite_to_chrome_style: Fix assert calling getName() when there's none When there's no identifier to rename, don't try to GetNameForDecl(), and always use getName() consistently. R=dcheng BUG=578344,581902 ==========
The CQ bit was unchecked by danakj@chromium.org
The CQ bit was checked by danakj@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642323002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642323002/40001
Message was sent while issue was closed.
Description was changed from ========== rewrite_to_chrome_style: Fix assert calling getName() when there's none When there's no identifier to rename, don't try to GetNameForDecl(), and always use getName() consistently. R=dcheng BUG=578344,581902 ========== to ========== rewrite_to_chrome_style: Fix assert calling getName() when there's none When there's no identifier to rename, don't try to GetNameForDecl(), and always use getName() consistently. R=dcheng BUG=578344,581902 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== rewrite_to_chrome_style: Fix assert calling getName() when there's none When there's no identifier to rename, don't try to GetNameForDecl(), and always use getName() consistently. R=dcheng BUG=578344,581902 ========== to ========== rewrite_to_chrome_style: Fix assert calling getName() when there's none When there's no identifier to rename, don't try to GetNameForDecl(), and always use getName() consistently. R=dcheng BUG=578344,581902 Committed: https://crrev.com/98ce11e5cca3e666a5034d85eab5823eaaec259a Cr-Commit-Position: refs/heads/master@{#372245} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/98ce11e5cca3e666a5034d85eab5823eaaec259a Cr-Commit-Position: refs/heads/master@{#372245} |
