third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp - Issue 1642283002: Deal with frame removal by content scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp

Issue 1642283002: Deal with frame removal by content scripts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Last nits Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/PluginDocument.cpp ('k') | third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp b/third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp

index cc5344d24e8ff07e7371e4340fbfbfc544fc5005..be72275e02a68dbe8831b25dd1cbe98a5638c44b 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp

+++ b/third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp

@@ -383,8 +383,11 @@ PassRefPtrWillBeRawPtr<HTMLFormElement> HTMLConstructionSite::takeForm()

void HTMLConstructionSite::dispatchDocumentElementAvailableIfNeeded()

{

ASSERT(m_document);

- if (m_document->frame() && !m_isParsingFragment)

+ if (m_document->frame() && !m_isParsingFragment) {

m_document->frame()->loader().dispatchDocumentElementAvailable();

+ m_document->frame()->loader().runScriptsAtDocumentElementAvailable();

+ // runScriptsAtDocumentElementAvailable might have invalidated m_document.

+ }

}

void HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML(AtomicHTMLToken* token)