third_party/WebKit/Source/core/html/MediaDocument.cpp - Issue 1642283002: Deal with frame removal by content scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/MediaDocument.cpp

Issue 1642283002: Deal with frame removal by content scripts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Last nits Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/MediaDocument.cpp

diff --git a/third_party/WebKit/Source/core/html/MediaDocument.cpp b/third_party/WebKit/Source/core/html/MediaDocument.cpp

index 525d869dbb2ff380d5110f98d9e9b3d3e17ac593..3435ebd037dbe23c5481dda4aebc720cc748087e 100644

--- a/third_party/WebKit/Source/core/html/MediaDocument.cpp

+++ b/third_party/WebKit/Source/core/html/MediaDocument.cpp

@@ -75,8 +75,10 @@ void MediaDocumentParser::createDocumentStructure()

rootElement->insertedByParser();

document()->appendChild(rootElement);

- if (document()->frame())

- document()->frame()->loader().dispatchDocumentElementAvailable();

+ document()->frame()->loader().dispatchDocumentElementAvailable();

+ document()->frame()->loader().runScriptsAtDocumentElementAvailable();

+ if (isDetached())

+ return; // runScriptsAtDocumentElementAvailable can detach the frame.

RefPtrWillBeRawPtr<HTMLHeadElement> head = HTMLHeadElement::create(*document());

RefPtrWillBeRawPtr<HTMLMetaElement> meta = HTMLMetaElement::create(*document());