third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp - Issue 1642283002: Deal with frame removal by content scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp

Issue 1642283002: Deal with frame removal by content scripts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add more runScriptsAtDocumentElementAvailable + comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp

diff --git a/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp b/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp

index 2d87cd5784e4a66a840126a9904ff9764e4b7a47..8f5516643920f3ef0a3898966ac619e353df9891 100644

--- a/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp

+++ b/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp

@@ -1071,8 +1071,11 @@ void XMLDocumentParser::startElementNs(const AtomicString& localName, const Atom

if (isHTMLHtmlElement(*newElement))

toHTMLHtmlElement(*newElement).insertedByParser();

- if (!m_parsingFragment && isFirstElement && document()->frame())

+ if (!m_parsingFragment && isFirstElement && document()->frame()) {

document()->frame()->loader().dispatchDocumentElementAvailable();

+ document()->frame()->loader().runScriptsAtDocumentElementAvailable();

+ // runScriptsAtDocumentElementAvailable might have invalidated the document.

+ }

}

void XMLDocumentParser::endElementNs()