content/renderer/render_frame_impl.h - Issue 1642283002: Deal with frame removal by content scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.h

Issue 1642283002: Deal with frame removal by content scripts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add more runScriptsAtDocumentElementAvailable + comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_frame_impl.h

diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h

index 09e743ab5f4d7231dc98894827a028e8b54fa31c..3dd0f3ed36ec6743d477442a505545e83f9f9af5 100644

--- a/content/renderer/render_frame_impl.h

+++ b/content/renderer/render_frame_impl.h

@@ -486,6 +486,8 @@ class CONTENT_EXPORT RenderFrameImpl

void didCreateNewDocument(blink::WebLocalFrame* frame) override;

void didClearWindowObject(blink::WebLocalFrame* frame) override;

void didCreateDocumentElement(blink::WebLocalFrame* frame) override;

+ void runScriptsAtDocumentElementAvailable(

+ blink::WebLocalFrame* frame) override;

void didReceiveTitle(blink::WebLocalFrame* frame,

const blink::WebString& title,

blink::WebTextDirection direction) override;

@@ -493,6 +495,7 @@ class CONTENT_EXPORT RenderFrameImpl

blink::WebIconURL::Type icon_type) override;

void didFinishDocumentLoad(blink::WebLocalFrame* frame,

bool document_is_empty) override;

+ void runScriptsAtDocumentReady(blink::WebLocalFrame* frame) override;

void didHandleOnloadEvents(blink::WebLocalFrame* frame) override;

void didFailLoad(blink::WebLocalFrame* frame,

const blink::WebURLError& error,