extensions/renderer/dispatcher.h - Issue 1642283002: Deal with frame removal by content scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/dispatcher.h

Issue 1642283002: Deal with frame removal by content scripts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Up to #50: ExtensionFrameHelper callbacks, comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/dispatcher.h

diff --git a/extensions/renderer/dispatcher.h b/extensions/renderer/dispatcher.h

index 40194a06d2ab6a40e83b300a226098bcbfb8aa26..8e64ab550cc1c837d02fa7920fe16fe227014cc3 100644

--- a/extensions/renderer/dispatcher.h

+++ b/extensions/renderer/dispatcher.h

@@ -108,7 +108,12 @@ class Dispatcher : public content::RenderProcessObserver,

v8::Local<v8::Context> v8_context,

const GURL& url);

+ // This method is not allowed to run JavaScript code in the frame.

void DidCreateDocumentElement(blink::WebLocalFrame* frame);

+ // These methods may run (untrusted) JavaScript code in the frame, and

Devlin 2016/02/16 18:37:37 nit: let's put a newline after line 112.

+ // cause |render_frame| to become invalid.

+ void AfterDidCreateDocumentElement(content::RenderFrame* render_frame);

+ void AfterDidFinishDocumentLoad(content::RenderFrame* render_frame);

void OnExtensionResponse(int request_id,

bool success,