Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: extensions/renderer/extension_frame_helper.cc

Issue 1642283002: Deal with frame removal by content scripts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Push down WeakPtr Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/extension_frame_helper.cc
diff --git a/extensions/renderer/extension_frame_helper.cc b/extensions/renderer/extension_frame_helper.cc
index c063f84a169ba2a5d6915b6cdc121647f9b93e2c..fd0179207be5e977cdabe1eba2ebf956bb4bfd38 100644
--- a/extensions/renderer/extension_frame_helper.cc
+++ b/extensions/renderer/extension_frame_helper.cc
@@ -123,6 +123,26 @@ void ExtensionFrameHelper::DidCreateNewDocument() {
did_create_current_document_element_ = false;
}
+void ExtensionFrameHelper::AfterDidCreateDocumentElement() {
+ DCHECK(did_create_current_document_element_);
+ base::WeakPtr<ExtensionFrameHelper> weak_self = AsWeakPtr();
+
+ // The JavaScript code can cause re-entrancy. To avoid a deadlock, don't run
+ // callbacks that are added during the iteration.
+ std::vector<base::Closure> callbacks;
+ document_element_created_callbacks_.swap(callbacks);
+ for (auto& callback : callbacks) {
+ callback.Run();
+ if (!weak_self.get())
+ return; // Frame and |this| invalidated by callback.
+ }
+}
+
+void ExtensionFrameHelper::ScheduleAfterDidCreateDocumentElement(
+ const base::Closure& callback) {
+ document_element_created_callbacks_.push_back(callback);
+}
+
void ExtensionFrameHelper::DidMatchCSS(
const blink::WebVector<blink::WebString>& newly_matching_selectors,
const blink::WebVector<blink::WebString>& stopped_matching_selectors) {

Powered by Google App Engine
This is Rietveld 408576698