Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 164226: linux: fix race in TransportDIB passing (Closed)

Created:
11 years, 4 months ago by piman
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

linux: fix race in TransportDIB passing There was a race condition when the renderer passes a TransportDIB to the plugin process. It is possible that the renderer destroys the TransportDIB before the plugin handles the message, in which case the plugin will fail to map the shm handle. This also cleans up a couple of things. BUG=18320 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22949

Patch Set 1 #

Total comments: 3

Patch Set 2 : Add newline for clarity #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M chrome/common/transport_dib.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/transport_dib_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/plugin/webplugin_proxy.cc View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
piman
11 years, 4 months ago (2009-08-08 08:16:16 UTC) #1
Evan Martin
LGTM http://codereview.chromium.org/164226/diff/1/2 File chrome/common/transport_dib.h (right): http://codereview.chromium.org/164226/diff/1/2#newcode145 Line 145: DISALLOW_COPY_AND_ASSIGN(TransportDIB); Maybe extra newline above this? http://codereview.chromium.org/164226/diff/1/3 ...
11 years, 4 months ago (2009-08-09 05:24:11 UTC) #2
piman
11 years, 4 months ago (2009-08-10 20:40:20 UTC) #3
http://codereview.chromium.org/164226/diff/1/2
File chrome/common/transport_dib.h (right):

http://codereview.chromium.org/164226/diff/1/2#newcode145
Line 145: DISALLOW_COPY_AND_ASSIGN(TransportDIB);
On 2009/08/09 05:24:11, Evan Martin wrote:
> Maybe extra newline above this?

Done.

Powered by Google App Engine
This is Rietveld 408576698