Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 164223002: Add missing x11 checks in StickyKeysHandler. (Closed)

Created:
6 years, 10 months ago by kalyank
Modified:
6 years, 10 months ago
Reviewers:
Tim Song
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add missing x11 checks in StickyKeysHandler. We guard all calls to AppendNativeEventMask with X11 platform checks. It appends native masks and are defined only on X11 platform. This CL adds the missing check in AppendNativeEventMask. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251225

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ash/sticky_keys/sticky_keys_controller.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
kalyank
6 years, 10 months ago (2014-02-13 18:34:12 UTC) #1
Tim Song
lgtm
6 years, 10 months ago (2014-02-13 18:53:35 UTC) #2
kalyank
The CQ bit was checked by kalyan.kondapally@intel.com
6 years, 10 months ago (2014-02-13 18:57:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalyan.kondapally@intel.com/164223002/1
6 years, 10 months ago (2014-02-13 18:59:46 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 19:37:10 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests, check_deps, ...
6 years, 10 months ago (2014-02-13 19:37:10 UTC) #6
kalyank
The CQ bit was checked by kalyan.kondapally@intel.com
6 years, 10 months ago (2014-02-13 22:30:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalyan.kondapally@intel.com/164223002/1
6 years, 10 months ago (2014-02-13 22:33:26 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 01:49:21 UTC) #9
Message was sent while issue was closed.
Change committed as 251225

Powered by Google App Engine
This is Rietveld 408576698