src/api-natives.h - Issue 1642223003: [api] Make ObjectTemplate::SetNativeDataProperty() work even if the ObjectTemplate does not have a …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api-natives.h

Issue 1642223003: [api] Make ObjectTemplate::SetNativeDataProperty() work even if the ObjectTemplate does not have a … (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Removed asserts preventing JSReceiver properties in ObjectTemplate Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/api-natives.h

diff --git a/src/api-natives.h b/src/api-natives.h

index fcca4a5a17e63834cd001adcd242b9ceb9ef34d9..91f0b168d92830a5a365a43ad486c672d3edd7e0 100644

--- a/src/api-natives.h

+++ b/src/api-natives.h

@@ -25,10 +25,6 @@ class ApiNatives {

MUST_USE_RESULT static MaybeHandle<JSObject> InstantiateObject(

Handle<ObjectTemplateInfo> data);

- MUST_USE_RESULT static MaybeHandle<FunctionTemplateInfo> ConfigureInstance(

- Isolate* isolate, Handle<FunctionTemplateInfo> instance,

- Handle<JSObject> data);

enum ApiInstanceType {

JavaScriptObjectType,

GlobalObjectType,

« no previous file with comments | « src/api.cc ('k') | src/api-natives.cc » ('j') | no next file with comments »