Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Side by Side Diff: src/api-natives.h

Issue 1642223003: [api] Make ObjectTemplate::SetNativeDataProperty() work even if the ObjectTemplate does not have a … (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Removed asserts preventing JSReceiver properties in ObjectTemplate Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/api.cc ('k') | src/api-natives.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_API_NATIVES_H_ 5 #ifndef V8_API_NATIVES_H_
6 #define V8_API_NATIVES_H_ 6 #define V8_API_NATIVES_H_
7 7
8 #include "src/handles.h" 8 #include "src/handles.h"
9 #include "src/property-details.h" 9 #include "src/property-details.h"
10 10
11 namespace v8 { 11 namespace v8 {
12 namespace internal { 12 namespace internal {
13 13
14 // Forward declarations. 14 // Forward declarations.
15 class ObjectTemplateInfo; 15 class ObjectTemplateInfo;
16 class TemplateInfo; 16 class TemplateInfo;
17 17
18 class ApiNatives { 18 class ApiNatives {
19 public: 19 public:
20 static const int kInitialFunctionCacheSize = 256; 20 static const int kInitialFunctionCacheSize = 256;
21 21
22 MUST_USE_RESULT static MaybeHandle<JSFunction> InstantiateFunction( 22 MUST_USE_RESULT static MaybeHandle<JSFunction> InstantiateFunction(
23 Handle<FunctionTemplateInfo> data); 23 Handle<FunctionTemplateInfo> data);
24 24
25 MUST_USE_RESULT static MaybeHandle<JSObject> InstantiateObject( 25 MUST_USE_RESULT static MaybeHandle<JSObject> InstantiateObject(
26 Handle<ObjectTemplateInfo> data); 26 Handle<ObjectTemplateInfo> data);
27 27
28 MUST_USE_RESULT static MaybeHandle<FunctionTemplateInfo> ConfigureInstance(
29 Isolate* isolate, Handle<FunctionTemplateInfo> instance,
30 Handle<JSObject> data);
31
32 enum ApiInstanceType { 28 enum ApiInstanceType {
33 JavaScriptObjectType, 29 JavaScriptObjectType,
34 GlobalObjectType, 30 GlobalObjectType,
35 GlobalProxyType 31 GlobalProxyType
36 }; 32 };
37 33
38 static Handle<JSFunction> CreateApiFunction(Isolate* isolate, 34 static Handle<JSFunction> CreateApiFunction(Isolate* isolate,
39 Handle<FunctionTemplateInfo> obj, 35 Handle<FunctionTemplateInfo> obj,
40 Handle<Object> prototype, 36 Handle<Object> prototype,
41 ApiInstanceType instance_type); 37 ApiInstanceType instance_type);
(...skipping 13 matching lines...) Expand all
55 PropertyAttributes attributes); 51 PropertyAttributes attributes);
56 52
57 static void AddNativeDataProperty(Isolate* isolate, Handle<TemplateInfo> info, 53 static void AddNativeDataProperty(Isolate* isolate, Handle<TemplateInfo> info,
58 Handle<AccessorInfo> property); 54 Handle<AccessorInfo> property);
59 }; 55 };
60 56
61 } // namespace internal 57 } // namespace internal
62 } // namespace v8 58 } // namespace v8
63 59
64 #endif 60 #endif
OLDNEW
« no previous file with comments | « src/api.cc ('k') | src/api-natives.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698