Chromium Code Reviews| Index: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp |
| diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp |
| index 57b0a500fd251db7d23eb673bb89c288cf9a41de..90a07ae389aa0745cb31e598040e18e7278dbb0a 100644 |
| --- a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp |
| +++ b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp |
| @@ -1001,8 +1001,6 @@ void CompositedLayerMapping::updateScrollingLayerGeometry(const IntRect& localCo |
| m_foregroundLayer->setNeedsDisplay(); |
| m_foregroundLayer->setOffsetFromLayoutObject(m_scrollingContentsLayer->offsetFromLayoutObject()); |
| } |
| - |
| - updateScrollingBlockSelection(); |
| } |
| void CompositedLayerMapping::updateChildClippingMaskLayerGeometry() |
| @@ -1198,35 +1196,6 @@ void CompositedLayerMapping::updateContentsOffsetInCompositingLayer(const IntPoi |
| m_contentOffsetInCompositingLayerDirty = false; |
| } |
| -void CompositedLayerMapping::updateScrollingBlockSelection() |
| -{ |
| - if (RuntimeEnabledFeatures::selectionPaintingWithoutSelectionGapsEnabled()) |
| - return; |
| - |
| - if (!m_scrollingBlockSelectionLayer) |
| - return; |
| - |
| - if (!m_scrollingContentsAreEmpty) { |
| - // In this case, the selection will be painted directly into m_scrollingContentsLayer. |
| - m_scrollingBlockSelectionLayer->setDrawsContent(false); |
|
chrishtr
2016/01/28 22:06:22
delete m_scrollingBlockSelectionLayer?
wkorman
2016/01/28 22:54:32
Done.
|
| - return; |
| - } |
| - |
| - const IntRect blockSelectionGapsBounds = m_owningLayer.blockSelectionGapsBounds(); |
| - const bool shouldDrawContent = !blockSelectionGapsBounds.isEmpty(); |
| - m_scrollingBlockSelectionLayer->setDrawsContent(shouldDrawContent); |
| - if (!shouldDrawContent) |
| - return; |
| - // FIXME: Remove the flooredIntSize conversion. crbug.com/414283. |
| - const IntPoint position = blockSelectionGapsBounds.location() + flooredIntSize(m_owningLayer.scrollableArea()->adjustedScrollOffset()); |
| - if (m_scrollingBlockSelectionLayer->size() == blockSelectionGapsBounds.size() && m_scrollingBlockSelectionLayer->position() == position) |
| - return; |
| - |
| - m_scrollingBlockSelectionLayer->setPosition(position); |
| - m_scrollingBlockSelectionLayer->setSize(FloatSize(blockSelectionGapsBounds.size())); |
| - m_scrollingBlockSelectionLayer->setOffsetFromLayoutObject(toIntSize(blockSelectionGapsBounds.location()), GraphicsLayer::SetNeedsDisplay); |
| -} |
| - |
| void CompositedLayerMapping::updateDrawsContent() |
| { |
| bool hasPaintedContent = containsPaintedContent(); |
| @@ -1237,7 +1206,6 @@ void CompositedLayerMapping::updateDrawsContent() |
| // m_scrollingContentsLayer only needs backing store if the scrolled contents need to paint. |
| m_scrollingContentsAreEmpty = !m_owningLayer.hasVisibleContent() || !(layoutObject()->hasBackground() || paintsChildren()); |
| m_scrollingContentsLayer->setDrawsContent(!m_scrollingContentsAreEmpty); |
| - updateScrollingBlockSelection(); |
| } |
| if (hasPaintedContent && isAcceleratedCanvas(layoutObject())) { |
| @@ -1639,12 +1607,6 @@ bool CompositedLayerMapping::updateScrollingLayers(bool needsScrollingLayers) |
| m_scrollingContentsLayer = createGraphicsLayer(CompositingReasonLayerForScrollingContents); |
| m_scrollingLayer->addChild(m_scrollingContentsLayer.get()); |
| - if (!RuntimeEnabledFeatures::selectionPaintingWithoutSelectionGapsEnabled()) { |
| - m_scrollingBlockSelectionLayer = createGraphicsLayer(CompositingReasonLayerForScrollingBlockSelection); |
| - m_scrollingBlockSelectionLayer->setDrawsContent(true); |
| - m_scrollingContentsLayer->addChild(m_scrollingBlockSelectionLayer.get()); |
| - } |
| - |
| layerChanged = true; |
| if (scrollingCoordinator) { |
| scrollingCoordinator->scrollableAreaScrollLayerDidChange(m_owningLayer.scrollableArea()); |