Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1642213002: Move font_warmup_win, fix webrtc dep. (Closed)

Created:
4 years, 10 months ago by brettw
Modified:
4 years, 10 months ago
Reviewers:
scottmg
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move font_warmup_win, fix webrtc dep. font_warmup_win.cc depends on Blink code but is linked into content/common. This file is not needed outside of child processes, so it can go in content/child and avoid the blink-in-browser usage. Removes the linux conditional on libjingle_webrtc and make it apply whenever webrtc is being used. This code is called by socket_host.cc whenever webrtc is enabled. This is necessary for a future patch that removes Blink's linking into content/browser. Blink is currently bringing in webrtc which is why the code links today. BUG=582206 Committed: https://crrev.com/f94a6cd48ef99bb585a8724801040300c4937854 Cr-Commit-Position: refs/heads/master@{#372210}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1057 lines) Patch
M content/browser/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
M content/child/dwrite_font_proxy/dwrite_font_proxy_init_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/child/font_warmup_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/child/font_warmup_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/child/font_warmup_win_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D content/common/font_warmup_win.h View 1 chunk +0 lines, -76 lines 0 comments Download
D content/common/font_warmup_win.cc View 1 chunk +0 lines, -529 lines 0 comments Download
D content/common/font_warmup_win_unittest.cc View 1 chunk +0 lines, -435 lines 0 comments Download
M content/content_child.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +1 line, -1 line 0 comments Download
M content/ppapi_plugin/ppapi_plugin_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/ppapi_plugin/ppapi_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_main_platform_delegate_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/layouttest_support.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
brettw
4 years, 10 months ago (2016-01-28 21:22:07 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642213002/20001
4 years, 10 months ago (2016-01-28 21:28:48 UTC) #6
scottmg
lgtm
4 years, 10 months ago (2016-01-28 21:31:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642213002/20001
4 years, 10 months ago (2016-01-28 21:42:46 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-28 23:57:40 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 23:58:36 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f94a6cd48ef99bb585a8724801040300c4937854
Cr-Commit-Position: refs/heads/master@{#372210}

Powered by Google App Engine
This is Rietveld 408576698