Issue 164218: Merge 22237 - Replace the guts of AudioRendererBase with calls to scaling alg...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164218: Merge 22237 - Replace the guts of AudioRendererBase with calls to scaling alg... (Closed)

Created:
11 years, 4 months ago by laforge

Modified:
9 years, 7 months ago

Reviewers:
kylep

CC:
chromium-reviews_googlegroups.com, fbarchard, Alpha Left Google, jam, kylep, awong, darin (slow to review), brettw, scherkus (not reviewing)

Base URL:
svn://chrome-svn/chrome/branches/195/src/

Visibility:
Public.

Merge 22237 - Replace the guts of AudioRendererBase with calls to scaling algorithm. BUG=16011 TEST=audio_renderer_base_unittest.cc and buffer_queue_unittest.cc Review URL: http://codereview.chromium.org/155695 TBR=kylep@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22846

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+182 lines, -226 lines)			Patch
MM	chrome/renderer/media/audio_renderer_impl.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
MM	chrome/renderer/media/audio_renderer_impl.cc	View	5 chunks	+7 lines, -9 lines	0 comments	Download
MM	media/base/buffer_queue.h	View	2 chunks	+6 lines, -3 lines	0 comments	Download
MM	media/base/buffer_queue.cc	View	3 chunks	+21 lines, -7 lines	0 comments	Download
MM	media/base/buffer_queue_unittest.cc	View	1 chunk	+34 lines, -23 lines	0 comments	Download
MM	media/base/mock_filters.h	View	3 chunks	+12 lines, -1 line	0 comments	Download
MM	media/filters/audio_renderer_algorithm_base.h	View	2 chunks	+6 lines, -3 lines	0 comments	Download
MM	media/filters/audio_renderer_algorithm_base.cc	View	5 chunks	+13 lines, -12 lines	0 comments	Download
MM	media/filters/audio_renderer_base.h	View	6 chunks	+11 lines, -17 lines	0 comments	Download
MM	media/filters/audio_renderer_base.cc	View	9 chunks	+58 lines, -116 lines	0 comments	Download
MM	media/filters/audio_renderer_base_unittest.cc	View	4 chunks	+8 lines, -6 lines	0 comments	Download
MM	media/filters/audio_renderer_impl.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
MM	media/filters/audio_renderer_impl.cc	View	3 chunks	+3 lines, -5 lines	0 comments	Download
MM	media/filters/null_audio_renderer.h	View	2 chunks	+0 lines, -6 lines	0 comments	Download
MM	media/filters/null_audio_renderer.cc	View	3 chunks	+3 lines, -9 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM