Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1642143004: Change .gitignore to ignore /base instead of /base/trace_event/common. (Closed)

Created:
4 years, 10 months ago by Lei Zhang
Modified:
4 years, 10 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Change .gitignore to ignore /base instead of /base/trace_event/common. BUG=581960 LOG=N Committed: https://crrev.com/bb96455b61715c078a97317fd111eee81c59fb12 Cr-Commit-Position: refs/heads/master@{#33621}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M .gitignore View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642143004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642143004/1
4 years, 10 months ago (2016-01-29 21:40:11 UTC) #2
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
4 years, 10 months ago (2016-01-29 21:40:12 UTC) #4
Lei Zhang
4 years, 10 months ago (2016-01-29 21:42:02 UTC) #6
adamk
lgtm
4 years, 10 months ago (2016-01-29 21:44:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642143004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642143004/1
4 years, 10 months ago (2016-01-29 21:49:26 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-29 22:12:09 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 22:12:38 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb96455b61715c078a97317fd111eee81c59fb12
Cr-Commit-Position: refs/heads/master@{#33621}

Powered by Google App Engine
This is Rietveld 408576698