Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 10 months ago by Lei Zhang Modified:
4 years, 10 months ago Reviewers:
adamk CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionChange .gitignore to ignore /base instead of /base/trace_event/common.
BUG=581960
LOG=N
Committed: https://crrev.com/bb96455b61715c078a97317fd111eee81c59fb12
Cr-Commit-Position: refs/heads/master@{#33621}
Patch Set 1 #
Created: 4 years, 10 months ago
Messages
Total messages: 14 (7 generated)
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642143004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642143004/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-v8-committers". Note that this has nothing to do with OWNERS files.
thestig@chromium.org changed reviewers: + adamk@chromium.org
Description was changed from ========== Change .gitignore to ignore /base instead of /base/trace_event/common. BUG=581960 ========== to ========== Change .gitignore to ignore /base instead of /base/trace_event/common. BUG=581960 LOG=N ==========
lgtm
The CQ bit was checked by thestig@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642143004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642143004/1
Message was sent while issue was closed.
Description was changed from ========== Change .gitignore to ignore /base instead of /base/trace_event/common. BUG=581960 LOG=N ========== to ========== Change .gitignore to ignore /base instead of /base/trace_event/common. BUG=581960 LOG=N ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Change .gitignore to ignore /base instead of /base/trace_event/common. BUG=581960 LOG=N ========== to ========== Change .gitignore to ignore /base instead of /base/trace_event/common. BUG=581960 LOG=N Committed: https://crrev.com/bb96455b61715c078a97317fd111eee81c59fb12 Cr-Commit-Position: refs/heads/master@{#33621} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/bb96455b61715c078a97317fd111eee81c59fb12 Cr-Commit-Position: refs/heads/master@{#33621} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
