chromecast/media/cma/backend/alsa/stream_mixer_alsa.cc - Issue 1642143003: [Chromecast] Log sample rate changes and tweak audio logging output.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/media/cma/backend/alsa/stream_mixer_alsa.cc

Issue 1642143003: [Chromecast] Log sample rate changes and tweak audio logging output. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chromecast/media/cma/backend/alsa/audio_decoder_alsa.cc ('k') | chromecast/media/cma/backend/alsa/stream_mixer_alsa_input_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/media/cma/backend/alsa/stream_mixer_alsa.cc

diff --git a/chromecast/media/cma/backend/alsa/stream_mixer_alsa.cc b/chromecast/media/cma/backend/alsa/stream_mixer_alsa.cc

index 53df6133550a2e3ddbb7d12e26d47165fc272632..b782ed359122db28465578125762105b879a8cc3 100644

--- a/chromecast/media/cma/backend/alsa/stream_mixer_alsa.cc

+++ b/chromecast/media/cma/backend/alsa/stream_mixer_alsa.cc

@@ -347,6 +347,8 @@ int StreamMixerAlsa::SetAlsaPlaybackParams() {

}

output_samples_per_second_ =

static_cast<int>(unsigned_output_samples_per_second);

+ LOG(INFO) << "Sample rate changed from " << output_samples_per_second_

kmackay 2016/01/28 23:25:41 Seems like this should be moved up above the line

jyw 2016/01/28 23:39:22 Done.

+ << " to " << unsigned_output_samples_per_second;

snd_pcm_uframes_t requested_buffer_size = alsa_buffer_size_;

RETURN_ERROR_CODE(PcmHwParamsSetBufferSizeNear, pcm_, pcm_hw_params_,