[interpreter] Add a safety-net for interpreter entry.

[interpreter] Add a safety-net for interpreter entry.

This adds debug code to the interpreter entry trampoline to ensure that
the called bytecode handler will never return, but instead tear down the
frame with a proper exit trampoline eventually.

R=rmcilroy@chromium.org

Committed: https://crrev.com/5f42a625643ac5c75d91085bb5a627331086b223
Cr-Commit-Position: refs/heads/master@{#33585}

[rmcilroy, 2016-01-28 14:18:58]

LGTM, thanks!

https://codereview.chromium.org/1642063002/diff/1/src/x87/builtins-x87.cc
File src/x87/builtins-x87.cc (right):

https://codereview.chromium.org/1642063002/diff/1/src/x87/builtins-x87.cc#new...
src/x87/builtins-x87.cc:649: // trampoline.
nit - you can remove the nop() here now.

[rmcilroy, 2016-01-28 14:24:06]

LGTM++ thanks for the comment change!

[Michael Starzinger, 2016-01-28 14:30:39]

Thanks. Addressed comments. Landing.

https://codereview.chromium.org/1642063002/diff/1/src/x87/builtins-x87.cc
File src/x87/builtins-x87.cc (right):

https://codereview.chromium.org/1642063002/diff/1/src/x87/builtins-x87.cc#new...
src/x87/builtins-x87.cc:649: // trampoline.
On 2016/01/28 14:18:58, rmcilroy wrote:
> nit - you can remove the nop() here now.

Done.

[Michael Starzinger, 2016-01-28 14:32:41]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2016-01-28 14:32:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1642063002/#ps40001
(title: "Addressed comment.")

[commit-bot: I haz the power, 2016-01-28 14:32:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1642063002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1642063002/40001

[commit-bot: I haz the power, 2016-01-28 14:55:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-28 14:55:44]

Description was changed from

==========
[interpreter] Add a safety-net for interpreter entry.

This adds debug code to the interpreter entry trampoline to ensure that
the called bytecode handler will never return, but instead tear down the
frame with a proper exit trampoline eventually.

R=rmcilroy@chromium.org
==========

to

==========
[interpreter] Add a safety-net for interpreter entry.

This adds debug code to the interpreter entry trampoline to ensure that
the called bytecode handler will never return, but instead tear down the
frame with a proper exit trampoline eventually.

R=rmcilroy@chromium.org

Committed: https://crrev.com/5f42a625643ac5c75d91085bb5a627331086b223
Cr-Commit-Position: refs/heads/master@{#33585}
==========

[commit-bot: I haz the power, 2016-01-28 14:55:44]

Patchset 3 (id:??) landed as
https://crrev.com/5f42a625643ac5c75d91085bb5a627331086b223
Cr-Commit-Position: refs/heads/master@{#33585}