Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Side by Side Diff: tests/BitmapTest.cpp

Issue 164203003: replace setConfig+allocPixels with alloc-or-install-pixels (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tests/BitmapHeapTest.cpp ('k') | tests/BlitRowTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2013 Google Inc. 2 * Copyright 2013 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkBitmap.h" 8 #include "SkBitmap.h"
9 9
10 #include "Test.h" 10 #include "Test.h"
11 11
12 static void test_bigwidth(skiatest::Reporter* reporter) { 12 static void test_bigwidth(skiatest::Reporter* reporter) {
13 SkBitmap bm; 13 SkBitmap bm;
14 int width = 1 << 29; // *4 will be the high-bit of 32bit int 14 int width = 1 << 29; // *4 will be the high-bit of 32bit int
15 15
16 REPORTER_ASSERT(reporter, bm.setConfig(SkBitmap::kA8_Config, width, 1)); 16 SkImageInfo info = SkImageInfo::Make(width, 1, kAlpha_8_SkColorType,
17 REPORTER_ASSERT(reporter, bm.setConfig(SkBitmap::kRGB_565_Config, width, 1)) ; 17 kPremul_SkAlphaType);
18 REPORTER_ASSERT(reporter, bm.setConfig(info));
19 info.fColorType = kRGB_565_SkColorType;
20 REPORTER_ASSERT(reporter, bm.setConfig(info));
18 21
19 // for a 4-byte config, this width will compute a rowbytes of 0x80000000, 22 // for a 4-byte config, this width will compute a rowbytes of 0x80000000,
20 // which does not fit in a int32_t. setConfig should detect this, and fail. 23 // which does not fit in a int32_t. setConfig should detect this, and fail.
21 24
22 // TODO: perhaps skia can relax this, and only require that rowBytes fit 25 // TODO: perhaps skia can relax this, and only require that rowBytes fit
23 // in a uint32_t (or larger), but for now this is the constraint. 26 // in a uint32_t (or larger), but for now this is the constraint.
24 27
25 REPORTER_ASSERT(reporter, !bm.setConfig(SkBitmap::kARGB_8888_Config, width, 1)); 28 info.fColorType = kPMColor_SkColorType;
29 REPORTER_ASSERT(reporter, !bm.setConfig(info));
26 } 30 }
27 31
28 /** 32 /**
29 * This test contains basic sanity checks concerning bitmaps. 33 * This test contains basic sanity checks concerning bitmaps.
30 */ 34 */
31 DEF_TEST(Bitmap, reporter) { 35 DEF_TEST(Bitmap, reporter) {
32 const SkBitmap::Config conf = SkBitmap::kARGB_8888_Config;
33 // Zero-sized bitmaps are allowed 36 // Zero-sized bitmaps are allowed
34 for (int width = 0; width < 2; ++width) { 37 for (int width = 0; width < 2; ++width) {
35 for (int height = 0; height < 2; ++height) { 38 for (int height = 0; height < 2; ++height) {
36 SkBitmap bm; 39 SkBitmap bm;
37 bool setConf = bm.setConfig(conf, width, height); 40 bool setConf = bm.setConfig(SkImageInfo::MakeN32Premul(width,
41 height));
38 REPORTER_ASSERT(reporter, setConf); 42 REPORTER_ASSERT(reporter, setConf);
39 if (setConf) { 43 if (setConf) {
40 REPORTER_ASSERT(reporter, bm.allocPixels(NULL)); 44 REPORTER_ASSERT(reporter, bm.allocPixels(NULL));
41 } 45 }
42 REPORTER_ASSERT(reporter, SkToBool(width & height) != bm.empty()); 46 REPORTER_ASSERT(reporter, SkToBool(width & height) != bm.empty());
43 } 47 }
44 } 48 }
45 49
46 test_bigwidth(reporter); 50 test_bigwidth(reporter);
47 } 51 }
OLDNEW
« no previous file with comments | « tests/BitmapHeapTest.cpp ('k') | tests/BlitRowTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698