Don't modify the clipstack in saveLayer() if the kClipToLayer_SaveFlag is

Fix saveLayer() clipping w/filters, GPU path.

Don't modify the clipstack in saveLayer() if the kClipToLayer_SaveFlag is
not set. Without this the GPU path will clip the offscreen to the layer's
bounds, even if the flag is not set.

R=robertphillips@google.com
BUG=skia:

Committed: https://code.google.com/p/skia/source/detail?r=13561

[Stephen White, 2014-02-13 18:29:10]

Rob: PTAL. Thanks!

[reed1, 2014-02-13 18:57:40]

https://codereview.chromium.org/164203002/diff/20001/tests/CanvasStateTest.cpp
File tests/CanvasStateTest.cpp (right):

https://codereview.chromium.org/164203002/diff/20001/tests/CanvasStateTest.cp...
tests/CanvasStateTest.cpp:236: bitmap.setConfig(SkBitmap::kARGB_8888_Config,
WIDTH, HEIGHT);
nit: try using the new pattern for this:

bitmap.allocN32Pixels(WIDTH, HEIGHT);

it replaces setConfig(...)+allocPixels()

[Stephen White, 2014-02-13 19:04:52]

On 2014/02/13 18:57:40, reed1 wrote:
> https://codereview.chromium.org/164203002/diff/20001/tests/CanvasStateTest.cpp
> File tests/CanvasStateTest.cpp (right):
> 
>
https://codereview.chromium.org/164203002/diff/20001/tests/CanvasStateTest.cp...
> tests/CanvasStateTest.cpp:236: bitmap.setConfig(SkBitmap::kARGB_8888_Config,
> WIDTH, HEIGHT);
> nit: try using the new pattern for this:
> 
> bitmap.allocN32Pixels(WIDTH, HEIGHT);
> 
> it replaces setConfig(...)+allocPixels()

Done. Thanks!

[robertphillips, 2014-02-13 19:12:34]

lgtm + 1 question

https://codereview.chromium.org/164203002/diff/60001/tests/CanvasStateTest.cpp
File tests/CanvasStateTest.cpp (right):

https://codereview.chromium.org/164203002/diff/60001/tests/CanvasStateTest.cp...
tests/CanvasStateTest.cpp:251: 
without -> with in comment?

[Stephen White, 2014-02-24 15:16:46]

Committed patchset #3 manually as r13561 (presubmit successful).