Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Unified Diff: third_party/WebKit/public/platform/WebProcessMemoryDump.h

Issue 1642023007: Refactoring: Move functions from WebMemoryDumpProviderAdapter to PartitionAllocMemoryDumpProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: haraken's review Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/WebProcessMemoryDump.h
diff --git a/third_party/WebKit/public/platform/WebProcessMemoryDump.h b/third_party/WebKit/public/platform/WebProcessMemoryDump.h
index 39ec7ef74d0edec9c4ccecbed6b3e37e23673995..1a1014c873a82e6e8d56abad6b255626e772c60d 100644
--- a/third_party/WebKit/public/platform/WebProcessMemoryDump.h
+++ b/third_party/WebKit/public/platform/WebProcessMemoryDump.h
@@ -12,6 +12,14 @@
class SkTraceMemoryDump;
+namespace base {
+namespace trace_event {
+
+class ProcessMemoryDump;
+
+} // namespace trace_event
+} // namespace base
+
namespace blink {
// A container which holds all the dumps for the various allocators for a given
@@ -103,6 +111,16 @@ public:
BLINK_ASSERT_NOT_REACHED();
return nullptr;
}
+
+ // TODO(hajimehoshi): This is a temporary hack to use ProcessMemoryDump
+ // from PartitionAllocMemoryDumpProvider. Remove this after we move
+ // WebProcessMemoryDumpImpl from content/child to platform. See
+ // crbug/548254.
+ virtual base::trace_event::ProcessMemoryDump* getProcessMemoryDump()
+ {
+ BLINK_ASSERT_NOT_REACHED();
+ return nullptr;
+ }
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698