Refactoring: Move functions from WebMemoryDumpProviderAdapter to PartitionAllocMemoryDumpProvider

content/child/web_process_memory_dump_impl.h

Index: content/child/web_process_memory_dump_impl.h
diff --git a/content/child/web_process_memory_dump_impl.h b/content/child/web_process_memory_dump_impl.h
index ff351434ea9a0429a77302d4ebb0b2bdf64191e5..34304de4ecc91b6ffffbbfc820e5ae7c970e6aca 100644
--- a/content/child/web_process_memory_dump_impl.h
+++ b/content/child/web_process_memory_dump_impl.h
@@ -75,6 +75,8 @@ class CONTENT_EXPORT WebProcessMemoryDumpImpl final
       const std::string& name,
       base::DiscardableMemory* discardable);
 
+  base::trace_event::ProcessMemoryDump* getProcessMemoryDump() override;

[Primiano Tucci (use gerrit), 2016/02/01 13:50:00]

The only weird thing here is that with this CL you are now in a state where most
of the code that uses memory-infra use the wrapped WebProcessMemoryDump, but now
you are cutting a hole through the layers here to get directly to the
base::trace_event::PMD.

It seems that here you want just the SessionState, so why not just adding a
method like:

base::trace_event__MemoryDumpSessionState* getMemoryDumpSessionState()
here ?

[hajimehoshi, 2016/02/02 08:44:44]

Makes sense. Unfortunately, not only the session state but also calling DumpInto
are required here. I crated WebProcessMemoryDump::dumpPartitionAllocHeapUsage
instead of getProcessMemoryDump, and moved the logic using ProcessMemoryDump* to
the new function. I think we would need more refactoring since the new method is
used only for Parition Alloc.

+
  private:
   FRIEND_TEST_ALL_PREFIXES(WebProcessMemoryDumpImplTest, IntegrationTest);