Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1642023002: depot_tools: import bot_update gclient git rietveld tryserver recipe modules (Closed)

Created:
4 years, 10 months ago by Paweł Hajdan Jr.
Modified:
4 years, 10 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

depot_tools: import bot_update gclient git rietveld tryserver recipe modules BUG=582074 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298447

Patch Set 1 #

Patch Set 2 : bot_update.py #

Patch Set 3 : resources #

Patch Set 4 : works? #

Patch Set 5 : standalone #

Patch Set 6 : presubmit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8436 lines, --1 lines) Patch
A recipe_modules/bot_update/__init__.py View 1 chunk +12 lines, -0 lines 0 comments Download
A recipe_modules/bot_update/api.py View 1 2 3 1 chunk +276 lines, -0 lines 0 comments Download
A recipe_modules/bot_update/example.py View 1 2 3 1 chunk +155 lines, -0 lines 0 comments Download
A recipe_modules/bot_update/example.expected/basic.json View 1 2 3 1 chunk +52 lines, -0 lines 0 comments Download
A recipe_modules/bot_update/example.expected/basic_output_manifest.json View 1 2 3 1 chunk +59 lines, -0 lines 0 comments Download
A recipe_modules/bot_update/example.expected/basic_with_branch_heads.json View 1 2 3 1 chunk +53 lines, -0 lines 0 comments Download
A recipe_modules/bot_update/example.expected/clobber.json View 1 2 3 1 chunk +40 lines, -0 lines 0 comments Download
A recipe_modules/bot_update/example.expected/forced.json View 1 2 3 1 chunk +53 lines, -0 lines 0 comments Download
A recipe_modules/bot_update/example.expected/no_shallow.json View 1 2 3 1 chunk +40 lines, -0 lines 0 comments Download
A recipe_modules/bot_update/example.expected/off.json View 1 2 3 1 chunk +39 lines, -0 lines 0 comments Download
A recipe_modules/bot_update/example.expected/reset_root_solution_revision.json View 1 2 3 1 chunk +39 lines, -0 lines 0 comments Download
A recipe_modules/bot_update/example.expected/svn_mode.json View 1 2 3 1 chunk +55 lines, -0 lines 0 comments Download
A recipe_modules/bot_update/example.expected/trychange.json View 1 2 3 1 chunk +54 lines, -0 lines 0 comments Download
A recipe_modules/bot_update/example.expected/trychange_oauth2.json View 1 2 3 1 chunk +56 lines, -0 lines 0 comments Download
A recipe_modules/bot_update/example.expected/tryjob.json View 1 2 3 1 chunk +54 lines, -0 lines 0 comments Download
A recipe_modules/bot_update/example.expected/tryjob_fail.json View 1 2 3 1 chunk +56 lines, -0 lines 0 comments Download
A recipe_modules/bot_update/example.expected/tryjob_fail_patch.json View 1 2 3 1 chunk +78 lines, -0 lines 0 comments Download
A recipe_modules/bot_update/example.expected/tryjob_fail_patch_download.json View 1 2 3 1 chunk +78 lines, -0 lines 0 comments Download
A recipe_modules/bot_update/example.expected/tryjob_v8.json View 1 2 3 1 chunk +57 lines, -0 lines 0 comments Download
A + recipe_modules/bot_update/resources/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A recipe_modules/bot_update/resources/bot_update.py View 1 2 3 4 1 chunk +1741 lines, -0 lines 0 comments Download
A recipe_modules/bot_update/test_api.py View 1 2 3 1 chunk +86 lines, -0 lines 0 comments Download
A recipe_modules/gclient/__init__.py View 1 chunk +9 lines, -0 lines 0 comments Download
A recipe_modules/gclient/api.py View 1 2 3 1 chunk +309 lines, -0 lines 0 comments Download
A recipe_modules/gclient/config.py View 1 2 3 1 chunk +88 lines, -0 lines 0 comments Download
A recipe_modules/gclient/example.py View 1 2 3 1 chunk +51 lines, -0 lines 0 comments Download
A recipe_modules/gclient/example.expected/basic.json View 1 2 3 1 chunk +157 lines, -0 lines 0 comments Download
A recipe_modules/gclient/example.expected/revision.json View 1 2 3 1 chunk +159 lines, -0 lines 0 comments Download
A recipe_modules/gclient/example.expected/tryserver.json View 1 2 3 1 chunk +170 lines, -0 lines 0 comments Download
A recipe_modules/gclient/test_api.py View 1 chunk +37 lines, -0 lines 0 comments Download
A recipe_modules/git/__init__.py View 1 chunk +8 lines, -0 lines 0 comments Download
A recipe_modules/git/api.py View 1 2 3 4 5 1 chunk +349 lines, -0 lines 0 comments Download
A recipe_modules/git/example.py View 1 2 3 4 5 1 chunk +146 lines, -0 lines 0 comments Download
A recipe_modules/git/example.expected/basic.json View 1 2 3 1 chunk +165 lines, -0 lines 0 comments Download
A recipe_modules/git/example.expected/basic_branch.json View 1 2 3 1 chunk +165 lines, -0 lines 0 comments Download
A recipe_modules/git/example.expected/basic_file_name.json View 1 2 3 1 chunk +167 lines, -0 lines 0 comments Download
A recipe_modules/git/example.expected/basic_hash.json View 1 2 3 1 chunk +164 lines, -0 lines 0 comments Download
A recipe_modules/git/example.expected/basic_ref.json View 1 2 3 1 chunk +165 lines, -0 lines 0 comments Download
A recipe_modules/git/example.expected/basic_submodule_update_force.json View 1 2 3 1 chunk +166 lines, -0 lines 0 comments Download
A recipe_modules/git/example.expected/can_fail_build.json View 1 2 3 1 chunk +141 lines, -0 lines 0 comments Download
A recipe_modules/git/example.expected/cannot_fail_build.json View 1 2 3 1 chunk +169 lines, -0 lines 0 comments Download
A recipe_modules/git/example.expected/cat-file_test.json View 1 2 3 1 chunk +187 lines, -0 lines 0 comments Download
A recipe_modules/git/example.expected/count-objects_delta.json View 1 2 3 1 chunk +238 lines, -0 lines 0 comments Download
A recipe_modules/git/example.expected/count-objects_failed.json View 1 2 3 1 chunk +169 lines, -0 lines 0 comments Download
A recipe_modules/git/example.expected/count-objects_with_bad_output.json View 1 2 3 1 chunk +170 lines, -0 lines 0 comments Download
A recipe_modules/git/example.expected/count-objects_with_bad_output_fails_build.json View 1 2 3 1 chunk +90 lines, -0 lines 0 comments Download
A recipe_modules/git/example.expected/curl_trace_file.json View 1 2 3 1 chunk +169 lines, -0 lines 0 comments Download
A recipe_modules/git/example.expected/platform_win.json View 1 2 3 1 chunk +167 lines, -0 lines 0 comments Download
A recipe_modules/git/example.expected/rebase_failed.json View 1 2 3 1 chunk +167 lines, -0 lines 0 comments Download
A recipe_modules/git/example.expected/remote_not_origin.json View 1 2 3 1 chunk +167 lines, -0 lines 0 comments Download
A recipe_modules/git/example.expected/set_got_revision.json View 1 2 3 1 chunk +178 lines, -0 lines 0 comments Download
A recipe_modules/git/resources/git_setup.py View 1 2 1 chunk +61 lines, -0 lines 0 comments Download
A recipe_modules/git/test_api.py View 1 chunk +18 lines, -0 lines 0 comments Download
A recipe_modules/rietveld/__init__.py View 1 chunk +5 lines, -0 lines 0 comments Download
A recipe_modules/rietveld/api.py View 1 chunk +89 lines, -0 lines 0 comments Download
A recipe_modules/rietveld/example.py View 1 chunk +23 lines, -0 lines 0 comments Download
A recipe_modules/rietveld/example.expected/basic.json View 1 chunk +31 lines, -0 lines 0 comments Download
A recipe_modules/tryserver/__init__.py View 1 chunk +15 lines, -0 lines 0 comments Download
A recipe_modules/tryserver/api.py View 1 2 3 4 5 1 chunk +247 lines, -0 lines 0 comments Download
A recipe_modules/tryserver/example.py View 1 2 3 1 chunk +45 lines, -0 lines 0 comments Download
A recipe_modules/tryserver/example.expected/with_git_patch.json View 1 2 3 1 chunk +108 lines, -0 lines 0 comments Download
A recipe_modules/tryserver/example.expected/with_rietveld_patch.json View 1 2 3 1 chunk +60 lines, -0 lines 0 comments Download
A recipe_modules/tryserver/example.expected/with_svn_patch.json View 1 2 3 1 chunk +71 lines, -0 lines 0 comments Download
A recipe_modules/tryserver/example.expected/with_wrong_patch.json View 1 2 3 1 chunk +37 lines, -0 lines 0 comments Download
A recipe_modules/tryserver/test_api.py View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642023002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642023002/60001
4 years, 10 months ago (2016-01-28 14:11:23 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_presubmit/builds/365)
4 years, 10 months ago (2016-01-28 14:16:00 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642023002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642023002/80001
4 years, 10 months ago (2016-01-28 14:19:40 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_presubmit/builds/368)
4 years, 10 months ago (2016-01-28 14:24:20 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642023002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642023002/100001
4 years, 10 months ago (2016-01-28 14:26:20 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-01-28 14:28:31 UTC) #13
M-A Ruel
rs lgtm
4 years, 10 months ago (2016-01-28 14:57:08 UTC) #15
M-A Ruel
On 2016/01/28 14:57:08, M-A Ruel wrote: > rs lgtm FTR, I have conflicted feelings about ...
4 years, 10 months ago (2016-01-28 14:59:16 UTC) #16
Paweł Hajdan Jr.
On 2016/01/28 at 14:59:16, maruel wrote: > FTR, I have conflicted feelings about rietveld and ...
4 years, 10 months ago (2016-01-28 15:01:06 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642023002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642023002/100001
4 years, 10 months ago (2016-01-28 15:02:24 UTC) #19
commit-bot: I haz the power
Committed patchset #6 (id:100001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=298447
4 years, 10 months ago (2016-01-28 15:04:44 UTC) #21
Paweł Hajdan Jr.
4 years, 10 months ago (2016-01-28 22:29:59 UTC) #22
Message was sent while issue was closed. 
A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1644173002/ by phajdan.jr@chromium.org.

The reason for reverting is: breakages:
https://code.google.com/p/chromium/issues/detail?id=582229.

Powered by Google App Engine
This is Rietveld 408576698