Issue 164201: Merge 22075 - Pipeline will execute a callback whenever an runtime error has ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164201: Merge 22075 - Pipeline will execute a callback whenever an runtime error has ... (Closed)

Created:
11 years, 4 months ago by laforge

Modified:
9 years, 7 months ago

Reviewers:
kylep

CC:
chromium-reviews_googlegroups.com, fbarchard, Alpha Left Google, kylep, awong, darin (slow to review), brettw, scherkus (not reviewing)

Base URL:
svn://chrome-svn/chrome/branches/195/src/

Visibility:
Public.

Description

Merge 22075 - Pipeline will execute a callback whenever an runtime error has happened. BUG=16738 TEST=pipeline_impl_unittest.cc Review URL: http://codereview.chromium.org/160298 TBR=kylep@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22819

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+81 lines, -3 lines)			Patch
MM	media/base/pipeline_impl.h	View	3 chunks	+7 lines, -1 line	0 comments	Download
MM	media/base/pipeline_impl.cc	View	2 chunks	+10 lines, -0 lines	0 comments	Download
MM	media/base/pipeline_impl_unittest.cc	View	5 chunks	+7 lines, -0 lines	0 comments	Download
MM	webkit/glue/webmediaplayer_impl.h	View	3 chunks	+6 lines, -0 lines	0 comments	Download
MM	webkit/glue/webmediaplayer_impl.cc	View	4 chunks	+51 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kylep

11 years, 4 months ago (2009-08-07 23:09:12 UTC) #2

LGTM

On Fri, Aug 7, 2009 at 3:58 PM, <laforge@chromium.org> wrote:

> Reviewers: kylep,
>
> Description:
> Merge 22075 - Pipeline will execute a callback whenever an runtime error
> has happened.
> BUG=16738
> TEST=pipeline_impl_unittest.cc
> Review URL: http://codereview.chromium.org/160298
>
> TBR=kylep@chromium.org
>
>
> Please review this at http://codereview.chromium.org/164201
>
> SVN Base: svn://chrome-svn/chrome/branches/195/src/
>
> Affected files:
>  MM    media/base/pipeline_impl.h
>  MM    media/base/pipeline_impl.cc
>  MM    media/base/pipeline_impl_unittest.cc
>  MM    webkit/glue/webmediaplayer_impl.h
>  MM    webkit/glue/webmediaplayer_impl.cc
>
>
>

Expand Messages | Collapse Messages