Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: gpu/command_buffer/service/buffer_manager.cc

Issue 16420008: Manual cherry pick of 204571 "Add workaround for Mali-400 zero-sized buffer bug." (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1500/src/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/buffer_manager.h ('k') | gpu/command_buffer/service/feature_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/buffer_manager.cc
===================================================================
--- gpu/command_buffer/service/buffer_manager.cc (revision 205634)
+++ gpu/command_buffer/service/buffer_manager.cc (working copy)
@@ -240,6 +240,11 @@
return usage == GL_STREAM_DRAW && use_client_side_arrays_for_stream_buffers_;
}
+bool BufferManager::UseNonZeroSizeForClientSideArrayBuffer() {
+ return feature_info_ && feature_info_->workarounds(
+ ).use_non_zero_size_for_client_side_stream_buffers;
+}
+
void BufferManager::SetInfo(
Buffer* buffer, GLsizeiptr size, GLenum usage, const GLvoid* data) {
DCHECK(buffer);
@@ -268,7 +273,8 @@
ERRORSTATE_COPY_REAL_GL_ERRORS_TO_WRAPPER(error_state, "glBufferData");
if (IsUsageClientSideArray(usage)) {
- glBufferData(buffer->target(), 0, NULL, usage);
+ GLsizei empty_size = UseNonZeroSizeForClientSideArrayBuffer() ? 1 : 0;
+ glBufferData(buffer->target(), empty_size, NULL, usage);
} else {
glBufferData(buffer->target(), size, data, usage);
}
« no previous file with comments | « gpu/command_buffer/service/buffer_manager.h ('k') | gpu/command_buffer/service/feature_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698