Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: net/socket/client_socket_pool_base.cc

Issue 164200: Merge 21988 - Fix crash in client_socket_pool_base.cc.... (Closed) Base URL: svn://chrome-svn/chrome/branches/195/src/
Patch Set: Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/client_socket_pool_base.h ('k') | net/socket/client_socket_pool_base_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/client_socket_pool_base.cc
===================================================================
--- net/socket/client_socket_pool_base.cc (revision 22810)
+++ net/socket/client_socket_pool_base.cc (working copy)
@@ -130,9 +130,8 @@
connect_job_map_[handle] = job;
}
group.jobs.insert(job);
- } else {
- if (group.IsEmpty())
- group_map_.erase(group_name);
+ } else if (group.IsEmpty()) {
+ group_map_.erase(group_name);
}
return rv;
@@ -265,7 +264,6 @@
// Delete group if no longer needed.
if (group.IsEmpty()) {
- CHECK(group.pending_requests.empty());
group_map_.erase(i++);
} else {
++i;
@@ -457,7 +455,6 @@
// Delete group if no longer needed.
if (group.IsEmpty()) {
- CHECK(group.pending_requests.empty());
group_map_.erase(i++);
} else {
++i;
Property changes on: net\socket\client_socket_pool_base.cc
___________________________________________________________________
Modified: svn:mergeinfo
Merged /trunk/src/net/socket/client_socket_pool_base.cc:r21988
« no previous file with comments | « net/socket/client_socket_pool_base.h ('k') | net/socket/client_socket_pool_base_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698