Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 164198: Merge 21961 - The focus would be messedup when reloading a crashed tab, also ... (Closed)

Created:
11 years, 4 months ago by laforge
Modified:
9 years, 7 months ago
Reviewers:
jcampan
CC:
chromium-reviews_googlegroups.com, brettw, Ben Goodger (Google)
Visibility:
Public.

Description

Merge 21961 - The focus would be messedup when reloading a crashed tab, also causing accelerators to be broken. This CL also makes sure to keep the focus on the location bar when reloading the NTP. BUG=http://crbug.com/14954 TEST=See bug. Review URL: http://codereview.chromium.org/160206 TBR=jcampan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22809

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -3 lines) Patch
MM chrome/browser/browser.cc View 1 chunk +2 lines, -1 line 0 comments Download
MM chrome/browser/browser_focus_uitest.cc View 2 chunks +50 lines, -1 line 0 comments Download
MM chrome/browser/tab_contents/tab_contents.cc View 1 chunk +6 lines, -0 lines 0 comments Download
MM chrome/browser/views/tab_contents/tab_contents_view_win.cc View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/test/ui_test_utils.h View 2 chunks +3 lines, -0 lines 0 comments Download
MM chrome/test/ui_test_utils.cc View 3 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
laforge
11 years, 4 months ago (2009-08-07 22:34:09 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698