Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 164196: Merge 21937 - Nice and easy fix for the media clock interpolating past the du... (Closed)

Created:
11 years, 4 months ago by laforge
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, fbarchard, Alpha Left Google, kylep, awong, brettw, scherkus (not reviewing)
Visibility:
Public.

Description

Merge 21937 - Nice and easy fix for the media clock interpolating past the duration. I considered adding duration to Clock itself, but that felt like it would pollute Clock's simple purposes of keeping track of time. Furthermore, by keeping duration checking in PipelineImpl we can handle future scenarios such as streaming media where clock really should run forever. BUG=16508 TEST=currentTime should never exceed duration Review URL: http://codereview.chromium.org/159573 TBR=scherkus@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22807

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -8 lines) Patch
MM media/base/mock_filters.h View 1 chunk +6 lines, -0 lines 0 comments Download
MM media/base/pipeline_impl.cc View 1 chunk +5 lines, -1 line 0 comments Download
MM media/base/pipeline_impl_unittest.cc View 6 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
laforge
11 years, 4 months ago (2009-08-07 22:28:39 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698