Issue 164193009: Set -fobjc-call-cxx-cdtors in .m[m] files in the GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164193009: Set -fobjc-call-cxx-cdtors in .m[m] files in the GN build. (Closed)

Created:
6 years, 10 months ago by brettw

Modified:
6 years, 10 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Set -fobjc-call-cxx-cdtors in .m[m] files in the GN build. Previously this was being set for all .c[c] files on Mac. BUG=336480 R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251827

Patch Set 4 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	build/config/compiler/BUILD.gn	View	1 2	1 chunk	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

lgtm with comment fixed, thanks https://codereview.chromium.org/164193009/diff/40001/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/164193009/diff/40001/build/config/compiler/BUILD.gn#newcode79 build/config/compiler/BUILD.gn:79: cflags_objccc = [ "-fobjc-call-cxx-cdtors", ...

6 years, 10 months ago (2014-02-14 23:50:43 UTC) #2

brettw

6 years, 10 months ago (2014-02-18 20:42:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 manually as r251827 (presubmit successful).

Expand Messages | Collapse Messages

Issue 164193009: Set -fobjc-call-cxx-cdtors in .m[m] files in the GN build. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fixes #

Patch Set 4 : #

Messages