Chromium Code Reviews| Index: chrome/common/metrics/variations/variation_ids.h |
| diff --git a/chrome/common/metrics/variations/variation_ids.h b/chrome/common/metrics/variations/variation_ids.h |
| index 114f55ac3a23f318449549c73e882c581b4bdd7f..98e83ca2b3684aac1e3a3dbfcf08d8165cac3ea1 100644 |
| --- a/chrome/common/metrics/variations/variation_ids.h |
| +++ b/chrome/common/metrics/variations/variation_ids.h |
| @@ -282,15 +282,20 @@ enum ReservedVariationID { |
| IOS_PHONE_NEW_NTP_CONTROL_3_STABLE = 3312113, |
| // iOS Tablet New NTP trial. |
| - // Range: 3312104 - 3312107 (Beta); 3312108 - 3312111 (Stable) |
| + // Range: 3312104 - 3312107 (Beta); 3312108 - 3312111 (Unused); |
|
rohitrao (ping after 24h)
2014/02/14 22:35:43
It's probably worth using the deprecated/retired c
justincohen
2014/02/14 23:20:51
Done.
|
| + // 3312114 - 3312117 (Stable) |
| IOS_TABLET_NEW_NTP_OMNIBOX_HINT_BETA = 3312104, |
| IOS_TABLET_NEW_NTP_CONTROL_1_BETA = 3312105, |
| IOS_TABLET_NEW_NTP_FAKEBOX_HINT_BETA = 3312106, |
| IOS_TABLET_NEW_NTP_CONTROL_2_BETA = 3312107, |
| - IOS_TABLET_NEW_NTP_OMNIBOX_HINT_STABLE = 3312108, |
| - IOS_TABLET_NEW_NTP_CONTROL_1_STABLE = 3312109, |
| - IOS_TABLET_NEW_NTP_FAKEBOX_HINT_STABLE = 3312110, |
| - IOS_TABLET_NEW_NTP_CONTROL_2_STABLE = 3312111, |
| + IOS_TABLET_NEW_NTP_OMNIBOX_HINT_STABLE_UNUSED = 3312108, |
|
rohitrao (ping after 24h)
2014/02/14 22:35:43
Do you prefer _UNUSED, or the _MIN/_MAX format the
justincohen
2014/02/14 23:20:51
I went with MIN/MAX. I wasn't sure what to name i
|
| + IOS_TABLET_NEW_NTP_CONTROL_1_STABLE_UNUSED = 3312109, |
| + IOS_TABLET_NEW_NTP_FAKEBOX_HINT_STABLE_UNUSED = 3312110, |
| + IOS_TABLET_NEW_NTP_CONTROL_2_STABLE_UNUSED = 3312111, |
| + IOS_TABLET_NEW_NTP_OMNIBOX_HINT_STABLE = 3312114, |
| + IOS_TABLET_NEW_NTP_CONTROL_1_STABLE = 3312115, |
| + IOS_TABLET_NEW_NTP_FAKEBOX_HINT_STABLE = 3312116, |
| + IOS_TABLET_NEW_NTP_CONTROL_2_STABLE = 3312117, |
| // ExtensionInstallPrompt field trial. |
| EXTENSION_INSTALL_PROMPT_EXPERIMENT_ID_MIN = 3312051, |
| @@ -299,7 +304,7 @@ enum ReservedVariationID { |
| // NEXT ID: When adding new IDs, please add them above this section, starting |
| // with the value of NEXT_ID, and updating NEXT_ID to (end of your reserved |
| // range) + 1. |
| - NEXT_ID = 3312114, |
| + NEXT_ID = 3312118, |
| // USABLE IDs END HERE. |
| // |