Use new iOS NTP experiment ids.

Use new iOS NTP experiment ids.

BUG=
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252330

[justincohen, 2014-02-14 19:33:58]

This CL will need to be updated with the latest NEXT_ID when we are ready to
land it.  Is this the _UNUSED you wanted?

[rohitrao (ping after 24h), 2014-02-14 22:35:43]

https://codereview.chromium.org/164193008/diff/1/chrome/common/metrics/variat...
File chrome/common/metrics/variations/variation_ids.h (right):

https://codereview.chromium.org/164193008/diff/1/chrome/common/metrics/variat...
chrome/common/metrics/variations/variation_ids.h:277:
IOS_PHONE_NEW_NTP_OMNIBOX_HINT_STABLE = 3312100,
Tablet is actually ok, I think.  It's the phone stable IDs that we'll need to
change.

I don't think we need to bother updating the "V3" IDs, since we'll just drop
those groups completely.

https://codereview.chromium.org/164193008/diff/1/chrome/common/metrics/variat...
chrome/common/metrics/variations/variation_ids.h:285: // Range: 3312104 -
3312107 (Beta); 3312108 - 3312111 (Unused);
It's probably worth using the deprecated/retired comment format from other IDs,
as in line 142-148.

https://codereview.chromium.org/164193008/diff/1/chrome/common/metrics/variat...
chrome/common/metrics/variations/variation_ids.h:291:
IOS_TABLET_NEW_NTP_OMNIBOX_HINT_STABLE_UNUSED = 3312108,
Do you prefer _UNUSED, or the _MIN/_MAX format the suggest IDs use?

[justincohen, 2014-02-14 23:20:51]

PTAL

https://codereview.chromium.org/164193008/diff/1/chrome/common/metrics/variat...
File chrome/common/metrics/variations/variation_ids.h (right):

https://codereview.chromium.org/164193008/diff/1/chrome/common/metrics/variat...
chrome/common/metrics/variations/variation_ids.h:277:
IOS_PHONE_NEW_NTP_OMNIBOX_HINT_STABLE = 3312100,
I just removed V3.  Is that correct?

On 2014/02/14 22:35:43, rohitrao wrote:
> Tablet is actually ok, I think.  It's the phone stable IDs that we'll need to
> change.
> 
> I don't think we need to bother updating the "V3" IDs, since we'll just drop
> those groups completely.

https://codereview.chromium.org/164193008/diff/1/chrome/common/metrics/variat...
chrome/common/metrics/variations/variation_ids.h:285: // Range: 3312104 -
3312107 (Beta); 3312108 - 3312111 (Unused);
On 2014/02/14 22:35:43, rohitrao wrote:
> It's probably worth using the deprecated/retired comment format from other
IDs,
> as in line 142-148.

Done.

https://codereview.chromium.org/164193008/diff/1/chrome/common/metrics/variat...
chrome/common/metrics/variations/variation_ids.h:291:
IOS_TABLET_NEW_NTP_OMNIBOX_HINT_STABLE_UNUSED = 3312108,
I went with MIN/MAX.  I wasn't sure what to name it, tho, does
IOS_PHONE_NEW_NTP_2014_Q1_ID_MIN and IOS_PHONE_NEW_NTP_2014_Q1_ID2_MIN make
sense?

It seems a little odd.

On 2014/02/14 22:35:43, rohitrao wrote:
> Do you prefer _UNUSED, or the _MIN/_MAX format the suggest IDs use?

[justincohen, 2014-02-14 23:32:35]

rohitrao@ for review, asvitkine@ for OWNERS

PTAL

[Alexei Svitkine (slow), 2014-02-19 13:45:31]

lgtm

[Shuhei Takahashi, 2014-02-20 02:54:16]

Are you ready to commit this change? This change conflicts with my change
https://codereview.chromium.org/171973002/ .

[justincohen, 2014-02-20 03:25:20]

The CQ bit was checked by justincohen@chromium.org

[justincohen, 2014-02-20 03:50:19]

The CQ bit was unchecked by justincohen@chromium.org

[justincohen, 2014-02-20 03:50:30]

The CQ bit was checked by justincohen@chromium.org

[Shuhei Takahashi, 2014-02-20 06:12:57]

The CQ bit was unchecked by nya@chromium.org

[Shuhei Takahashi, 2014-02-20 06:13:04]

The CQ bit was checked by nya@chromium.org

[Shuhei Takahashi, 2014-02-20 07:16:59]

The CQ bit was unchecked by nya@chromium.org

[Shuhei Takahashi, 2014-02-20 07:17:05]

The CQ bit was checked by nya@chromium.org

[Shuhei Takahashi, 2014-02-20 09:04:46]

The CQ bit was unchecked by nya@chromium.org

[Shuhei Takahashi, 2014-02-20 09:04:51]

The CQ bit was checked by nya@chromium.org

[commit-bot: I haz the power, 2014-02-20 09:32:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/justincohen@chromium.org/164193008/60001

[commit-bot: I haz the power, 2014-02-20 12:42:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/justincohen@chromium.org/164193008/60001

[justincohen, 2014-02-20 17:09:33]

The CQ bit was unchecked by justincohen@chromium.org

[justincohen, 2014-02-20 17:09:38]

The CQ bit was checked by justincohen@chromium.org

[commit-bot: I haz the power, 2014-02-20 18:04:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-20 18:04:42]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[justincohen, 2014-02-20 18:05:18]

The CQ bit was checked by justincohen@chromium.org

[commit-bot: I haz the power, 2014-02-20 18:07:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/justincohen@chromium.org/164193008/60001

[commit-bot: I haz the power, 2014-02-20 18:39:55]

Change committed as 252330