Refactors the auto-launch logic and adds tests for it.

Refactors the auto-launch logic and adds tests for it.

Previously multiple views control 'auto-launch' status which is
complicated and not test-friendly. This CL separates the roles:
- SearchResultListView updates the auto-launch status based on
  the current settings. It can cancel by itself.
- SearchBoxView is responsible to cancel the auto-launch when
  the contents has changed.
- ContentsView still needs to ping SearchResultListView to
  update the auto-launch state, because only it knows the current
  show state.

BUG=341926
R=xiyuan@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251498

[xiyuan, 2014-02-14 04:55:55]

https://codereview.chromium.org/164193005/diff/1/ui/app_list/views/search_box...
File ui/app_list/views/search_box_view_unittest.cc (right):

https://codereview.chromium.org/164193005/diff/1/ui/app_list/views/search_box...
ui/app_list/views/search_box_view_unittest.cc:70: // Sets a long timeout to make
sure the timeout actualy happening in the
nit: Can we rephrase a bit?

// Sets a long timeout that lasts longer than the test run.

And maybe rename the function to SetLongAutoLaunchTimeout.
SetupAutoLaunchTimeout is too generic.

https://codereview.chromium.org/164193005/diff/1/ui/app_list/views/search_box...
ui/app_list/views/search_box_view_unittest.cc:127: (KeyPress(ui::VKEY_A));
Why we need to wrap KeyPress in ()?

https://codereview.chromium.org/164193005/diff/1/ui/app_list/views/search_res...
File ui/app_list/views/search_result_list_view.h (right):

https://codereview.chromium.org/164193005/diff/1/ui/app_list/views/search_res...
ui/app_list/views/search_result_list_view.h:36: explicit
SearchResultListView(SearchResultListViewDelegate* delegate,
nit: Remove explicit.

https://codereview.chromium.org/164193005/diff/1/ui/app_list/views/search_res...
File ui/app_list/views/search_result_list_view_unittest.cc (right):

https://codereview.chromium.org/164193005/diff/1/ui/app_list/views/search_res...
ui/app_list/views/search_result_list_view_unittest.cc:20: }
nit: // namespace

https://codereview.chromium.org/164193005/diff/1/ui/app_list/views/search_res...
ui/app_list/views/search_result_list_view_unittest.cc:41: // test case.
nit: Update comment and function name as the other test.

[Jun Mukai, 2014-02-14 19:17:27]

https://codereview.chromium.org/164193005/diff/1/ui/app_list/views/search_box...
File ui/app_list/views/search_box_view_unittest.cc (right):

https://codereview.chromium.org/164193005/diff/1/ui/app_list/views/search_box...
ui/app_list/views/search_box_view_unittest.cc:70: // Sets a long timeout to make
sure the timeout actualy happening in the
On 2014/02/14 04:55:55, xiyuan wrote:
> nit: Can we rephrase a bit?
> 
> // Sets a long timeout that lasts longer than the test run.
> 
> And maybe rename the function to SetLongAutoLaunchTimeout.
> SetupAutoLaunchTimeout is too generic.

Done.

https://codereview.chromium.org/164193005/diff/1/ui/app_list/views/search_box...
ui/app_list/views/search_box_view_unittest.cc:127: (KeyPress(ui::VKEY_A));
On 2014/02/14 04:55:55, xiyuan wrote:
> Why we need to wrap KeyPress in ()?

Done.

https://codereview.chromium.org/164193005/diff/1/ui/app_list/views/search_res...
File ui/app_list/views/search_result_list_view.h (right):

https://codereview.chromium.org/164193005/diff/1/ui/app_list/views/search_res...
ui/app_list/views/search_result_list_view.h:36: explicit
SearchResultListView(SearchResultListViewDelegate* delegate,
On 2014/02/14 04:55:55, xiyuan wrote:
> nit: Remove explicit.

Done.

https://codereview.chromium.org/164193005/diff/1/ui/app_list/views/search_res...
File ui/app_list/views/search_result_list_view_unittest.cc (right):

https://codereview.chromium.org/164193005/diff/1/ui/app_list/views/search_res...
ui/app_list/views/search_result_list_view_unittest.cc:20: }
On 2014/02/14 04:55:55, xiyuan wrote:
> nit: // namespace

Done.

https://codereview.chromium.org/164193005/diff/1/ui/app_list/views/search_res...
ui/app_list/views/search_result_list_view_unittest.cc:41: // test case.
On 2014/02/14 04:55:55, xiyuan wrote:
> nit: Update comment and function name as the other test.

Done.

[xiyuan, 2014-02-14 19:23:55]

lgtm

[Jun Mukai, 2014-02-14 19:28:48]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-02-14 19:30:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/164193005/150001

[commit-bot: I haz the power, 2014-02-14 19:52:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-14 19:52:12]

Try jobs failed on following builders: linux_chromium_rel

[Jun Mukai, 2014-02-14 20:24:00]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-02-14 20:25:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/164193005/480001

[commit-bot: I haz the power, 2014-02-14 20:49:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-14 20:49:12]

Retried try job too often on win_rel for step(s) app_list_unittests,
ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests,
check_deps, check_deps2git, chrome_elf_unittests, chromedriver_unittests,
components_unittests, compositor_unittests, content_browsertests,
content_unittests, crypto_unittests, events_unittests, google_apis_unittests,
gpu_unittests, installer_util_unittests, ipc_tests, jingle_unittests,
media_unittests, mini_installer_test, nacl_integration, ppapi_unittests,
printing_unittests, remoting_unittests, sql_unittests, sync_integration_tests,
sync_unit_tests, telemetry_perf_unittests, telemetry_unittests, views_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Jun Mukai, 2014-02-14 20:50:41]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-02-14 20:51:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/164193005/640001

[commit-bot: I haz the power, 2014-02-15 03:46:28]

Change committed as 251498